On Thu, 20 Nov 2025 22:26:26 GMT, David Holmes <[email protected]> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> David's comments
>
> src/hotspot/share/prims/jvm.cpp line 3668:
>
>> 3666: if (!DoJVMTIVirtualThreadTransitions) {
>> 3667: assert(!JvmtiExport::can_support_virtual_threads(), "sanity
>> check");
>> 3668: return;
>
> Does this not still need checking somewhere?
The check for `DoJVMTIVirtualThreadTransitions` was moved to the
`JVMTIStartTransition\JVMTIEndTransition` classes, but I guess you refer to the
assert: I missed to move it. Added now too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28361#discussion_r2561201839
