Hi Sebastiaan, the proposed change makes sense. I'm happy to commit it once a JOSM ticket has been created (for reference). Note that you can also use `CachedFile#getContentReader` to obtain a `BufferedReader`.
Regards, Simon On Mon, Sep 19, 2016 at 4:52 PM, Sebastiaan Couwenberg <sebas...@xs4all.nl> wrote: > Today an issue was reported for the josm Debian package about the Help > menu option causing an exception. [0] This turned out to be caused by > help-browser.css being moved out of the jar for the Debian package. > > Most code uses the CachedFile class to access embedded resources in jar, > and I wonder if the HelpBrowser shouldn't do so too. This would simplify > the patch included in the Debian package, and increase consistency in > the JOSM code. > > If there is interest for the above I'll forward the relevant changes [1] > for JOSM trunk in a Trac ticket. > > [0] https://bugs.debian.org/838247 > [1] > https://anonscm.debian.org/cgit/pkg-grass/josm.git/tree/debian/patches/06-move_data_out_of_jar.patch#n70 > > Kind Regards, > > Bas > > -- > GPG Key ID: 4096R/6750F10AE88D4AF1 > Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1 > > _______________________________________________ > josm-dev mailing list > josm-dev@openstreetmap.org > https://lists.openstreetmap.org/listinfo/josm-dev _______________________________________________ josm-dev mailing list josm-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/josm-dev