I noticed a few things (just on the code, didn't check the tests) 1 - donative == false; should be donative = false; 2 - The trigger on the parent is done before triggering the onfoo handler. 3 - Instead of the whole _preventDefault thing, just do donative = false inside the preventDefault function. 4 - Same could be done for stopPropagation, having a local var call bubble. Shorter, and we don't pollute the object. This one's just misc. 5 - We should somehow reuse the event object, both for performance and realism. Normally the event object remains thru bubbling (you can pass data,etc). 6 - This can be overkill when triggering events globally (consider Ajax Events). I think we should not bubble global + custom events where custom means "non-native".
Cheers -- Ariel Flesler http://flesler.blogspot.com/ On Sep 19, 12:18 am, "John Resig" <[EMAIL PROTECTED]> wrote: > Dan Webb has given us a patch for custom event > bubbling:http://dev.jquery.com/attachment/ticket/3379/bubble.patch > > Any thoughts? > > --John --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en -~----------~----~----~----~------~----~------~--~---
