On Fri, Sep 19, 2008 at 11:54 PM, Ariel Flesler <[EMAIL PROTECTED]> wrote:
> > I noticed a few things (just on the code, didn't check the tests) > > 1 - donative == false; should be donative = false; > 2 - The trigger on the parent is done before triggering the onfoo > handler. > 3 - Instead of the whole _preventDefault thing, just do donative = > false inside the preventDefault function. > 4 - Same could be done for stopPropagation, having a local var call > bubble. Shorter, and we don't pollute the object. This one's just > misc. All good points. I'll post an updated patch. > > 5 - We should somehow reuse the event object, both for performance and > realism. Normally the event object remains thru bubbling (you can pass > data,etc). The event object gets cloned so all the properties get preserved in the bubble. There could be some mileage in passing the original object along for performance reasons though. > > 6 - This can be overkill when triggering events globally (consider > Ajax Events). I think we should not bubble global + custom events > where custom means "non-native". Bubbling non-native events in the main use case for the patch. I think that trigger should bubble events just like when events are triggered from the browser. Thanks, -- Dan Webb http://www.danwebb.net aim: danwrong123 skype: danwrong --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en -~----------~----~----~----~------~----~------~--~---
