Juriy, you know my code and you have links showing I moved everything to proper feature testing because I believe it is a superior methodology.
This doesn't mean we have to throw away well tested object inference we have learned up to here. There is no need to jump away from working solutions, we just need to mix them with the new one in the correct way. On 27 Gen, 18:21, kangax <kan...@gmail.com> wrote: > On Jan 27, 11:34 am, Matt <m...@thekrusefamily.com> wrote: > > > On Jan 27, 7:12 am, Diego Perini <diego.per...@gmail.com> wrote: > > > > I just wrote in another thread that there are cases where I prefer to > > > use the following: > > > var IE = typeof document.fileSize !== 'undefined', // IE6, IE7 or IE8 > > > as a general boolean to detect any IE version > > > Is that really a good test? Do you know for a fact that no other > > browser has document.fileSize defined, and never will? And are using > > this test to apply fixes for features completely unrelated to > > document.fileSize? > Yes it is a good test if you use it to distinguish trident engine from others, no other browser has implemented that, and yes to the last questions...completely unrelated to the property but for sure related to being an IE browser. > No need to look for other browsers - one form element with `fileSize` > name attribute is enough to bring this test to its knees ;) IIRC, One "span" element with an id="length" will do much more damages to every existing framework/library, and there are tons of properties that can be overwritten. Should we also hope no other browser implements conditional comments ? Are you interested in how much a test is "foldable" or how good it is into recognize if the browser is IE ? First case you win, second case I win. > Diego didn't agree with me about weak nature of this check. > I agree with you about FT being a safer check than object inference in general, I do not agree the above test is weak for IE detection, it may result weak if you use it as a replacement for feature testing... Diego > -- > kangax --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to jquery-dev@googlegroups.com To unsubscribe from this group, send email to jquery-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en -~----------~----~----~----~------~----~------~--~---
