So I guess I got everything wrong ... you are planning to implement hasOwnProperty in every for in ... bad choice, imho, people do not need to use Object.prototype when $.each(o) instead of o.each() is basically the same number of characters/speed.
Code elegance to ruin performances? On Tue, Feb 24, 2009 at 9:45 PM, John Resig <[email protected]> wrote: > > Marcus - > > This is the current ticket that I'm tracking on the issue: > http://dev.jquery.com/ticket/2721 > > I currently have it on the 1.4 roadmap - but if you already have a > patch, I would love to see it (please attach it to the above ticket, > as well) - perhaps we can get something landed sooner, rather than > later. > > --John > > > > On Tue, Feb 24, 2009 at 4:04 PM, Marcus Pope <[email protected]> wrote: > > > > Of the 4 total bugs found when searching for hasOwnProperty, each one > > reports that jQuery doesn't support object prototype extensions > > because of some factor. In the most recent case a bug was closed > > invalid with the following explanation: > > > > "jQuery does not support changes to Object.prototype. The additional > > Object properties become visible to for-in loops and breaks any code > > that uses them. " > > > > After going through and editing the 30 or so references to unsafe > > for..in loops I was able to compile my application which extensively > > uses custom functions on the object prototype. I guess I'm confused > > as to why this cannot (or will not) be integrated into the jquery > > code. > > > > I'll admit I'm not a jQuery expert, but I couldn't find any code using > > inherited objects in the for..in iterations. Maybe it has something > > to do with jquery pluggins. > > > > Of course my solution is to modify the codebase every time a new > > version is released, but this seems pointless if making the iterations > > safe would resolve the problem altogether. > > > > Just curious, any info welcome. > > > > Thanks, > > Marcus > > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jQuery Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jquery-dev?hl=en -~----------~----~----~----~------~----~------~--~---
