Focusing on your DOM selector function ($): * It's good idea to add scoping since both querySelectorAll and getElementsByTagName can be called in the context of an element and not just the document. * AFAIK, .getElementsByTagName() returns a live set which is considered bad practice to use because of heavy performance penalties. I don't think that changed much since I last studied this subject. * Since you're not using the result of "a.match(...)" it's better to use "~a.search(...)" to just check for any match which is much faster.
HTH, ~Y On Oct 27, 10:32 pm, "Timothy J. Warren" <[email protected]> wrote: > On Thursday, October 27, 2011 4:28:25 PM UTC-4, Jake Verbaten wrote: > > > Great! Yet another library. > > > What's the point? > > The main point is to improve my javascript skills, and remove my dependency > on jQuery. > > Also, I wanted a way to easily mix and match modules. You can select to > just use the core, use just the dom module, whatever. -- To view archived discussions from the original JSMentors Mailman list: http://www.mail-archive.com/[email protected]/ To search via a non-Google archive, visit here: http://www.mail-archive.com/[email protected]/ To unsubscribe from this group, send email to [email protected]
