On Tue, Nov 1, 2011 at 12:24 AM, Timothy J. Warren <[email protected]>wrote:
> > > On Monday, October 31, 2011 12:27:09 PM UTC-4, Jake Verbaten wrote: >> >> Line >> 19<https://github.com/aviat4ion/kis-js/blob/master/src/modules/event.js#L19> >> You >> already checked the method exists, why check again >> >> It made sense at the time :/ > >> Line >> 40<http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#interface-eventtarget> >> Your >> calling `callback.apply(arguments)` instead of >> `callback.apply(arguments[0])`** >> > Corrected > >> Line >> 45<https://github.com/aviat4ion/kis-js/blob/master/src/modules/event.js#L45> >> Removing >> the event listener to stop double-bind is non-standard behaviour >> >> <https://github.com/aviat4ion/kis-js/blob/master/src/modules/event.js#L137> >> > I'm not aware of standard behavior > My bad I didn't read the standards<http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-eventtarget-addeventlistener> correctly. stopping double-bind is indeed standard behaviour. > Line > 137<https://github.com/aviat4ion/kis-js/blob/master/src/modules/event.js#L137> > Contains >> a "//todo implement it". Don't make it part of the public API if it doesnt >> work >> > Good point...no longer public > >> >> Where is event.fire/dispatch ? >> > Hmm...I'm not sure how to set that up. > el.dispatchEvent works in all modern browsers, el.fireEvent works in IE8. You need to fire an event object (document.createEventObject) in IE8 and you need to fire an Event (document.createEvent("Event")) in modern browsers. > >> You can also look at my >> EventTarget<http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#interface-eventtarget> >> >> Implementation<https://github.com/Raynos/DOM-shim/tree/master/src/interfaces/EventTarget/props> >> **for IE8. >> > > Thanks, but I'd rather not have to extract everything from your DOMShim > framework. My goal here is only to shim IE 8 > In this case the EventTarget only shims IE8. DOM-shim is IE8+ and EventTarget works in all other browsers. Nor do I imply you should copy or take the code. It's merely a piece of reference code. > -- > To view archived discussions from the original JSMentors Mailman list: > http://www.mail-archive.com/[email protected]/ > > To search via a non-Google archive, visit here: > http://www.mail-archive.com/[email protected]/ > > To unsubscribe from this group, send email to > [email protected] > -- To view archived discussions from the original JSMentors Mailman list: http://www.mail-archive.com/[email protected]/ To search via a non-Google archive, visit here: http://www.mail-archive.com/[email protected]/ To unsubscribe from this group, send email to [email protected]
