Modified the page accordingly. Which line are you talking about?
/Janne
On 9 Nov 2007, at 22:58, Craig L Russell wrote:
Hi Janne,
With svn instead of cvs, we might have to update the
SubmittingAPatch part. We might think of being more specific as to
the patch creation process:
To submit a patch, go to the trunk and do svn diff
>jspwiki-125.patch where jspwiki-125 is the jira issue.
The line "" seems to be unneeded, as it refers to itself.
Craig
On Nov 9, 2007, at 12:20 PM, Janne Jalkanen wrote:
Added some discussion to
http://www.jspwiki.org/wiki/ContributingChanges
How does that sound?
/Janne
On 9 Nov 2007, at 22:00, Janne Jalkanen wrote:
Sounds like a good policy to me. It also means that patches
don't disappear in the email inboxes - which often tends to happen.
As an example, the TitleBlock should probably be a separate
patch, and also the i18n change (as it impacts much more than
just a simple file), as well as the WikiRenamePageEvent. The
other stuff should go in right away, IMHO.
And separate patches, please. I really hate it when a patch has
multiple functionalities...
*sigh*
Too bad we don't have Git or Mercurial. It would be so much
easier to manage branches than with SVN...
/Janne
On 9 Nov 2007, at 21:39, Craig L Russell wrote:
Hi,
In order to attract community contributors it would be good to
standardize patch contributions.
Many other projects recommend for non-trivial patches, a JIRA to
be open and a patch to be attached to the JIRA. It's easier to
review patches attached to a JIRA; all you need to do is to
click on the attachment and it appears in a browser window.
Clearly any committer has the ability to commit at will. But if
the patch needs to be reviewed, a JIRA issue with a discussion
is a great way to capture everyone's feedback in one place.
Regards,
Craig
On Nov 9, 2007, at 11:20 AM, Janne Jalkanen wrote:
* the TitleBlock.jsp and JSP/CSS changes to accommodate, with
changes
as per Dirk's suggestions
These are dirk's domain...
* the i18n patches that separate the greeting and following
message as
used by UserBox.jsp (including the changes to the JSP)
Didn't take these in, as the patch wasn't clean - it failed on
everything but English. Also, they seemed to have loads of
other changes as well, which I wasn't too comfortable with.
* slight modification/simplification to WikiPageEvent
* addition of WikiPageRenameEvent (I *thought* this was
already in CVS
and consider this a really necessary addition, otherwise
there's no
notification on page name changes)
* change of private to protected on a method in
LuceneSearchProvider to
permit extension
* added class info to error message output of ClassUtil
The rest are in.
I'm still wondering though why you don't put these in yourself
- you *do* have commit access to the CVS... ;-)
/Janne
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/
products/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!
