Janne Jalkanen wrote:
* the TitleBlock.jsp and JSP/CSS changes to accommodate, with changes
as per Dirk's suggestions
These are dirk's domain...
ok.
* the i18n patches that separate the greeting and following message as
used by UserBox.jsp (including the changes to the JSP)
Didn't take these in, as the patch wasn't clean - it failed on
everything but English. Also, they seemed to have loads of other
changes as well, which I wasn't too comfortable with.
I'd known there was some issue with encoding on diffs, or something
going wrong.
* slight modification/simplification to WikiPageEvent
* addition of WikiPageRenameEvent (I *thought* this was already in CVS
and consider this a really necessary addition, otherwise there's no
notification on page name changes)
* change of private to protected on a method in LuceneSearchProvider to
permit extension
* added class info to error message output of ClassUtil
The rest are in.
I'm still wondering though why you don't put these in yourself - you
*do* have commit access to the CVS... ;-)
Mostly for review, partly because I as unsure about several things, and
[certainly] partly because of lack of time -- I managed to get that patch
to you in the very small window of time I had. I haven't had the time to
figure to even look into the CVS yet. *sigh*
And apologies on not sending separate patches- could do that. Still not
sure what's up with the encoding -- I think you mentioned that all the
l10n stuff is Latin rather than UTF-8 so I'll check again and resend,
or if I find the time this weekend, commit to CVS. I'm more comfortable
on this encoding issue if I send and it fails than me committing a
wrongly-encoded file.
Murray
...........................................................................
Murray Altheim <murray07 at altheim.com> === = =
http://www.altheim.com/murray/ = = ===
SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
Boundless wind and moon - the eye within eyes,
Inexhaustible heaven and earth - the light beyond light,
The willow dark, the flower bright - ten thousand houses,
Knock at any door - there's one who will respond.
-- The Blue Cliff Record
