[ 
https://issues.apache.org/jira/browse/JSPWIKI-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559982#action_12559982
 ] 

Janne Jalkanen commented on JSPWIKI-139:
----------------------------------------

The problem with baseurl is that a fully blown JSPWiki system must be able to 
generate RSS feeds, and those need absolute URLs.  There are also some places 
where an absolute redirect is useful.

The same problem is with pathInfo - while it is available from the 
ServletRequest, you can't always rely on one being available.

My chief concern is introducing a new configuration item which most of the time 
replicates information in some other parameter.  This will cause a number of 
problems if there's a one-letter difference or some other typo, and will add to 
the headaches of an administrator...  So if there was any useful way to get rid 
of it, it would be great.

One option would be to guess it from the baseURL, and only allow users to 
override the basic guess, if it was wrong.

You might want to dig into the DefaultURLConstructor and 
ShortViewURLConstructor as well; there's already an overlap with 
shortviewurlconstructor.prefix with the basePath; and I think we might see some 
other problems there.

> Allow jspwiki pages to be at locations other than webapp root (for embedding)
> -----------------------------------------------------------------------------
>
>                 Key: JSPWIKI-139
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-139
>             Project: JSPWiki
>          Issue Type: Improvement
>    Affects Versions: 2.6.1
>            Reporter: Simon Kitching
>            Priority: Minor
>         Attachments: TemplateManager.patch, WikiEngine.patch
>
>
> The attached patches allow jspwiki pages to be deployed anywhere within a 
> webapp. In particular, the jspwiki engine can now be embedded within another 
> webapp and the pages placed in a subdirectory while still rendering in the 
> normal manner (http://host/webapp/somesubdir/Wiki.jsp?page=Foo).
> Note that embedded jspwiki usage has not been extensively tested; there may 
> be more patches required to allow full functionality. However this gets the 
> basics working at least.
> Patches are against cvs trunk as of about 15 Jan 2008.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to