Siegfried,

for the first issue:
I cannot reproduce the problem here (running the ant clean war target).
Is the "Find Pages" link pointing to something like "
http://localhost:8080/JSPWiki/Wiki.jsp?page=Search";.
And does your jspwiki.properties file contain the specialPage properties
like these (Search is a special page) :

jspwiki.specialPage.Search = Search.jsp


The second issue:
Webtests are very broken , we know that and plan to fix that at a later
time.
Do you consider this blocking? Should we (temporarily) outcomment the
webtests target, or perhaps we should document it somewhere.

The third issue

We can add the ASF License header to OldChangeLog,
tests/etc/TextFormattingRules.txt and
tests/etc/dependencyfindertasks.properties.

regards,
Harry





2012/11/9 Siegfried Goeschl <sgoes...@gmx.at>

> Hi folks,
>
> I had a look at the code and found the following problems
>
> 1) [Major] when I deploy the exploded WAR to my local Tomcat the "Find
> Pages" in the left hand navigation does not work -  it shows an
> non-existing Wiki page instead of opening a search page -  I tried with the
> LuceneSearchProvider and the BasicSearchProvider but it does not work. I
> did not see any error message in jspwiki.log but the fulltext search DOES
> work when using the "Quick Navigation"
>
> 2) [Major] when running "ant guitests" 17 out of my 962 test fail. Could
> be some missing configuration I'm not aware of but I would expect all tests
> to pass ... ;-)
>
> 3) [Minor] The RAT report could appreciate a few more exceptions to get
> rid of the "17 Unknown Licenses"
>
> Can anyone double-check? Currently (see 1+2) my vote is
>
> [ ] +1 Approve the release
> [X] -1 Disapprove the release (please provide specific comments)
>
> Thanks in advance
>
> Siegfried Goeschl
>
> PS: One handy thing I use for all of my ANT based projects - I use a
> "user.properties" which overwrites the value of "build.properties" but is
> EXCLUDED from version control. With that I can safely tinker with my local
> configuration settings without committing them accidently
>
> PSPS: - java version "1.6.0_37",  Java(TM) SE Runtime Environment (build
> 1.6.0_37-b06-434-11M3909), Java HotSpot(TM) 64-Bit Server VM (build
> 20.12-b01-434, mixed mode)
>
>
>
> On 01.11.12 22:32, Florian Holeczek wrote:
>
>> Hi all,
>>
>> I'd like to start a vote on an incubator release for Apache JSPWiki,
>> version 2.9.0-incubating.
>>
>> It fixes the following issues:
>> https://issues.apache.org/**jira/secure/ReleaseNote.jspa?**
>> projectId=12310732&version=**12319521<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310732&version=12319521>
>>
>> Note that we are voting upon the source (subversion tag and signed
>> artifacts). Binaries are provided for convenience only.
>>
>> The tag to be voted upon:
>> https://svn.apache.org/repos/**asf/incubator/jspwiki/tags/**
>> jspwiki_2_9_0_incubating<https://svn.apache.org/repos/asf/incubator/jspwiki/tags/jspwiki_2_9_0_incubating>
>>
>> Source and binary files:
>> http://people.apache.org/~**florianh/jspwiki-2.9.0-**incubating/<http://people.apache.org/~florianh/jspwiki-2.9.0-incubating/>
>>
>> Checksums:
>>
>> JSPWiki-2.9.0-incubating-src.**zip
>> MD5:    287e75857b03b41dca769211591c61**44
>> SHA1:   74b24e526177b7ddf5394b4b96b67b**b9081628a4
>> SHA512: 9a080ed994e4308e4ff6386f6e5e88**e42d27fc8a8abe37d2874d3c8477fe**
>> 097037017fffdd03430cdb0ca7a73e**fba91bf58e70c1943e08c956517080**9daa953a
>>
>> JSPWiki-2.9.0-incubating-bin.**zip
>> MD5:    7e774dc46c112ca895aad60fb607dc**60
>> SHA1:   e529eb02d13f4061534d85dd0e78d6**7c5dfe29a5
>> SHA512: 575eae72390178005bf7cf57332af9**a1da85515d6fc10cf9c8b3548f5074**
>> 3c0e57c0c6f46bc99b70cd1328ef08**3fb4a4fe9f3867e9ec7c7e4a640b84**5a2e2ee4
>>
>> JSPWiki's KEYS file containing PGP keys we use to sign the release:
>> http://www.apache.org/dist/**incubator/jspwiki/KEYS<http://www.apache.org/dist/incubator/jspwiki/KEYS>
>>
>>
>> *** Please download, test and vote by 72 hours from now.
>>
>>
>> Before voting, please review the section "What are the ASF requirements
>> on approving a release?" at http://www.apache.org/dev/**
>> release.html#approving-a-**release<http://www.apache.org/dev/release.html#approving-a-release>
>>
>> Please vote:
>>
>> [ ] +1 Approve the release
>> [ ] -1 Disapprove the release (please provide specific comments)
>>
>>
>> Best regards
>>  Florian Holeczek
>>
>
>

Reply via email to