Hi Siegfried, first, thanks for having had a thorough look at the stuff!
1) [Major] when I deploy the exploded WAR to my local Tomcat the "Find Pages" in the left hand navigation does not work - it shows an non-existing Wiki page instead of opening a search page - I tried with the LuceneSearchProvider and the BasicSearchProvider but it does not work. I did not see any error message in jspwiki.log but the fulltext search DOES work when using the "Quick Navigation"
you're probably using an old wiki page set, so this is expected behaviour. Please see https://issues.apache.org/jira/browse/JSPWIKI-664
2) [Major] when running "ant guitests" 17 out of my 962 test fail. Could be some missing configuration I'm not aware of but I would expect all tests to pass ... ;-)
The guitests target is not part of the build sequence for good reasons :-)
3) [Minor] The RAT report could appreciate a few more exceptions to get rid of the "17 Unknown Licenses"
I completely disagree in this point - The RAT report is nothing one will want to tell "Great, all fine!", in order to print it out and decorate some wall. Instead, it's only a helper tool that is meant to generate a good, unfiltered overview of reality. It's then up to the reader to interpret its contents. Putting exceptions into it means that you lose control over the ignored files and risk to oversee relevant issues in later modifications of these files.
Can anyone double-check? Currently (see 1+2) my vote is [ ] +1 Approve the release [X] -1 Disapprove the release (please provide specific comments)
The only issue IMO is no. 2 - but it's a minor issue that should not be blocking a release. WDYT? Regards Florian
