-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2013-12-17 23:08, Curtis Hovey-Canonical wrote: ...
> upgrade-juju on HP cloud broken in devel > https://bugs.launchpad.net/bugs/1255242 This bug could be fixed, or > mutated into the next bug, or just present but there are other bugs > that everyone will encounter first. > > upgrade is broken on hp and canonistack > https://bugs.launchpad.net/bugs/1260452 This bug reports that tools > cannot be found, or that > https://streams.canonical.com/juju/tools/streams/v1/index.json > 404s. Since every env specifies the tools-url to be the testing > location, and it has the tools, I cannot think of why Juju is not > honouring the instruction. I think the upgrade-juju fallout is a side effect of the patch for this bug: https://code.launchpad.net/~wallyworld/juju-core/refactor-deprecated-config-processing/+merge/198330 https://bugs.launchpad.net/juju-core/+bug/1256376 Bug #1256376: juju falsely claims that tools-metadata-url has ben supplied Ian moved the code to copy tools-url => tools-metadata-url out of config.Validate because Validate was being called multiple times. However, 'juju upgrade-juju' *also* uses Validate on the EnvironConfig it reads out of the Mongo DB before it goes off and searches for tools before upgrading. My initial instinct is to just revert the above merge for the time being. Alternatively we can make 'upgrade-juju' more directly aware of keys like tools-url needing to be copied into tools-metadata-url. (or always copy it during Validate but only Warn during Environ.Get().) I *think* we want to make sure that the server side jujud will also be able to handle if only tools-url is set in the EnvironConfig so it should be copying the data over. Right now the APIServer searches for tools using envtools.FindExactTools(env,...) and that env := environs.New(st.EnvironConfig()) I'm pretty sure that means we do call Validate (because it was called by New) but we *don't* call the new code that would be moving tools-url into tools-metadata-url. Which means that if you use juju-1.16 to upgrade your remote machines from 1.16 to 1.18 that we'll be broken for searching for tools-metadata-url as well. (Even if we fix the local upgrade-juju to rewrite the field, older clients won't, and the new server will stop rewriting the URL because of Ian's change.) John =:-> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (Cygwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlKxXsQACgkQJdeBCYSNAAOWPwCgsWwQUcomSjxz/4GsNTEpK6Cf LnQAniB3SAIsBCbdMVmlGEq7lzbO30AH =6QSW -----END PGP SIGNATURE----- -- Juju-dev mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
