I've just put my finishing touches to the HP cloud branch. I'd appreciate some reviews so we can unblock 1.17.0 and CI.
jam: I updated Instance with a Refresh method, so the bootstrap code no longer does the refresh-under-the-covers hack rogpeppe: I ended up doing what we briefly chatted about last night- each host checker now just attempts forever, until the Try is killed/closed. Much simpler now. Also, if you didn't notice, I fixed https://bugs.launchpad.net/juju-core/+bug/1259942 in this branch while I was at it. The fix for that dovetailed with verifying the host's identity. Cheers, Andrew On Wed, Dec 18, 2013 at 9:02 AM, Andrew Wilkins < [email protected]> wrote: > I started using goimports; I happened to have the shared repo in my > $GOPATH. > Sorry - fixed that import now. > > Cheers, > Andrew > > > On Wed, Dec 18, 2013 at 7:49 AM, David Cheney > <[email protected]>wrote: > >> >> >> >> On Wed, Dec 18, 2013 at 10:44 AM, Curtis Hovey-Canonical < >> [email protected]> wrote: >> >>> On Tue, Dec 17, 2013 at 6:14 PM, David Cheney >>> <[email protected]> wrote: >>> > The branch is not checked out properly. >>> >>> I don't see this path >>> $GOPATH/src/juju-core/ssh-options >>> in >>> >>> http://bazaar.launchpad.net/~axwalk/juju-core/lp1258240-bootstrap-refresh-dnsname-take2/files >>> or >>> trunk >>> >>> The make-release-tarball script >>> >>> http://bazaar.launchpad.net/~juju-qa/juju-core/ci-cd-scripts2/view/head:/make-release-tarball.bash >>> uses "go get -v -d launchpad.net/juju-core/..." >>> then uses bzr to force the version (and branch) to be the one under >>> test. Finally it runs godeps to set everything to be right version. >>> godeps is not happy. >>> >>> My use of a user branch is unorthodox, but I think it should work. I see >>> in >>> provider/common/bootstrap.go >>> an import of >>> "juju-core/ssh-options/utils/ssh" >>> >> >> This looks wrong, the import path should be >> >> import "launchpad.net/juju-core/utils/ssh" >> >> >>> but looking at his branch, I would think this path is actually trying to >>> import >>> >>> http://bazaar.launchpad.net/~axwalk/juju-core/lp1258240-bootstrap-refresh-dnsname-take2/view/head:/utils/ssh/ssh.go >>> >>> -- >>> Curtis Hovey >>> Canonical Cloud Development and Operations >>> http://launchpad.net/~sinzui >>> >>> -- >>> Juju-dev mailing list >>> [email protected] >>> Modify settings or unsubscribe at: >>> https://lists.ubuntu.com/mailman/listinfo/juju-dev >>> >> >> >> -- >> Juju-dev mailing list >> [email protected] >> Modify settings or unsubscribe at: >> https://lists.ubuntu.com/mailman/listinfo/juju-dev >> >> >
-- Juju-dev mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
