Yeah, this is the same issue that Ian brought up. I'm looking into it. Sorry for the pain.
-eric On Mon, Oct 20, 2014 at 5:31 PM, Dimiter Naydenov <[email protected]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hey Eric, > > Today I tried proposing a PR and the RB issue (#202) was created, but > it didn't have "Reviewers" field set (as described below), it wasn't > published (due to the former), but MOST importantly didn't have a diff > uploaded. After fiddling around with rbt I managed to do: > $ rbt diff > ~/patch > (while on the proposed feature branch) > > And then went to the RB issue page and manually uploaded the generated > diff and published it. > > So most definitely the hook generating RB issues have to upload the > diff as well :) > > It's coming together, keep up the good work! > > Cheers, > Dimiter > > On 20.10.2014 16:53, Eric Snow wrote: >> On Mon, Oct 20, 2014 at 6:06 AM, Ian Booth >> <[email protected]> wrote: >>> Hey Eric >>> >>> This is awesome, thank you. >>> >>> I did run into a gotcha - I created a PR and then looked at the >>> Incoming review queue and there was nothing new there. I then >>> clicked on All in the Outgoing review queue and saw that the >>> review was unpublished. I then went to publish it and it >>> complained at least one reviewer was needed. So I had to fill in >>> "juju-team" and all was good. >>> >>> 1. Can we make it so that the review is published automatically? >>> 2. Can we pre-fill "juju-team" as the reviewer? >> >> Good catch. The two are actually related. The review is >> published, but that fails because no reviewer got set. I'll get >> that fixed. >> >> -eric >> > > > - -- > Dimiter Naydenov <[email protected]> > juju-core team > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1 > > iQEcBAEBAgAGBQJURSrnAAoJENzxV2TbLzHw0BQH/16P4qPDI28kkGs398qRKY5s > eUtcHBpYs+JuLV2ZA0LjCpTds89RBDW6cKsxcfXxaAmawIb0KHh920VzKb1Wl2OT > z/iMOF2q91LnV58dqPf7mZjHaT1LPRdSRxg6aAZW/mjexwVRtRDT4Asd5w6JpKrH > 9Tkqfy86OilJ70X8qNbegvjJrBAttwoLLI4jwJq4dNWUbWCBbuumryh0k6+GlmNH > NiKbpi45pPy/RIFVA7ewbLIOpUXleHm5NIGlA/liZOMHpz0w5QHK3FYGLuGMNzQC > fq4qW6rfb1ITdr7XWsA3gooV6FUndw3mbNsod3QgSv82RDA6GGECHeYimGG94/g= > =POJ4 > -----END PGP SIGNATURE----- > > -- > Juju-dev mailing list > [email protected] > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev -- Juju-dev mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
