Why didn't you delete the code for the deprecated function?

On Sunday, July 31, 2016 at 2:31:56 AM UTC+2, Daniel Carrera wrote:
>
> Hello,
>
> I am trying to make a PR for JuliaStats and I have trouble figuring out 
> how to properly deprecate an old function. Apparently the @deprecate macro 
> redirects calls to the deprecated function into a new function. Ok, so I 
> can write an equivalent call using a new function. The problem is that now 
> the package fails the "Coverage" test. If all the calls to the old function 
> are redirected to some other function, the "coverage" of the package has 
> dropped... So I guess I'm still not doing the deprecation correctly. For 
> reference, this is the PR:
>
> https://github.com/JuliaStats/StatsBase.jl/pull/201
>
> I hope someone can help me figure out how to fix this and get the PR 
> passing all the tests.
>
> Cheers,
> Daniel.
>

Reply via email to