Thanks. I ended up figuring out what I needed to do by just experimenting with the different functions. It would be nice to have an explanation of these written down somewhere.
On Thursday, September 15, 2016 at 10:04:52 AM UTC-4, Daniel Carrera wrote: > > Yeah, you are supposed to delete the old code. @deprecate and depwarn > actually create a redirect of some sort, so that calls to the old function > are sent to the new function. > > > On 15 September 2016 at 09:54, Chris <[email protected] <javascript:>> > wrote: > >> Did you find any answers about this? I can't find anything about how to >> use these either. >> >> On Sunday, July 31, 2016 at 3:36:13 PM UTC-4, Daniel Carrera wrote: >>> >>> Oh... is that what I was supposed to do? I honestly didn't know. >>> >>> On 31 July 2016 at 18:02, Kristoffer Carlsson <[email protected]> >>> wrote: >>> >>>> Why didn't you delete the code for the deprecated function? >>>> >>>> On Sunday, July 31, 2016 at 2:31:56 AM UTC+2, Daniel Carrera wrote: >>>>> >>>>> Hello, >>>>> >>>>> I am trying to make a PR for JuliaStats and I have trouble figuring >>>>> out how to properly deprecate an old function. Apparently the @deprecate >>>>> macro redirects calls to the deprecated function into a new function. Ok, >>>>> so I can write an equivalent call using a new function. The problem is >>>>> that >>>>> now the package fails the "Coverage" test. If all the calls to the old >>>>> function are redirected to some other function, the "coverage" of the >>>>> package has dropped... So I guess I'm still not doing the deprecation >>>>> correctly. For reference, this is the PR: >>>>> >>>>> https://github.com/JuliaStats/StatsBase.jl/pull/201 >>>>> >>>>> I hope someone can help me figure out how to fix this and get the PR >>>>> passing all the tests. >>>>> >>>>> Cheers, >>>>> Daniel. >>>>> >>>> >>> >
