Matthias, Thanks for the additional clarification on your changes. It sounds like there has already been a good deal of improvement to the Shapefile IO code in OpenJUMP. At some point in the future I'd like to consider packaging some of the core into a separate library. I would include the Shapefile IO code in this library. If I get around to doing this, I may talk to the GeoTools folks about sharing code. This can be difficult, since they use a more complicated feature model than OJ, but we might be able to share things at a lower level.
The Sunburned Surveyor On Tue, Sep 14, 2010 at 8:24 AM, Matthias Scholz <m...@jammerhund.de> wrote: > Hi, > > after some days of holiday I hope I can clarify some things. > > 1. I've no problem if we switch in a future release to the GeoTools > Shapefile stuff. I made the changes on the actual code without any > knowledge about the history/reasons of that classes. We can gladly work > /test together on an integration of the actual GeoTools library. > (Sunburned Surveyor and Michaël's annotations) It makes sense for future > extensions/capabilities, such as common charset choise for all files > (Shape, GML...). > > 2. The charset settings will be automaticaly stored in the layer > properties through the org.openjump.core.ui.io.file.Options. If you add > such an option to a AbstractFileLayerLoader you get this option in the > OpenWizard and in the layer properties without any additional coding. > Please see org.openjump.OpenJumpConfiguration line 605 and below. > And if you save/load the project, this option will be automaticaly > saved/restored. This is a nice mechanism of OJ :-) > > 3. As the default charset is always the JVM default selected and used. > > 4. And now to the usability. If you make a doubleclick on the filename, > the shapefile will be directly openend. So you can save the following > clicks for the charset choise ;-) > But I like Stefan's suggestion with the option to enable/disable the > charset choise for the OpenWizard. The reason for my patches was simple. > In the past I had to open some files from different sources with > different charsets. It was annoying to change the OJ start stript > (-Dfile.encoding=...), start OJ, open the files, save theme in PostGIS, > close OJ and change the start script for the next file and so on. > I would implement a checkbox in the OptionsDialog. The question is in > which OptionPanel? Or should I make a new one? Here we can add some > additional file/dataset specific options in the future. > > Regards > > Matthias > > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
