Hi Matthias, Thanks for taking care of code consistency (hard work indeed).
I thought I would get no problem with the change you did in FeatureInstaller, because return type is not part of method signature, but I have to recompile extensions using FeatureInstaller (most of them) tomake them work (see error message hereafter with a recent plugin which has not been recompiled). I don't know why recompilation is required, but it's quite annoying that all plugins compiled against OpenJUMP 1.4.1 or less do not work with 1.4.2+. The worst is that we cannot keep both methods to deprecate old ones progressively as two methods with only a different return type cannot exist. Any idea somebody ? Here is the message starting OJ with FeatureInstaller change and an old plugin : java.lang.NoSuchMethodError: com.vividsolutions.jump.workbench.ui.plugin.FeatureInstaller.addMainMenuItem(Lcom/vividsolutions/jump/workbench/plugin/PlugIn;[Ljava/lang/String;Ljava/lang/String;ZLjavax/swing/Icon;Lcom/vividsolutions/jump/workbench/plugin/EnableCheck;)V at com.cadplan.jump.JumpChartPlugIn.initialize(JumpChartPlugIn.java:51) at com.cadplan.jump.JumpChartExtension.configure(JumpChartExtension.java:38) at com.vividsolutions.jump.workbench.plugin.PlugInManager.loadConfigurations(PlugInManager.java:92) at com.vividsolutions.jump.workbench.plugin.PlugInManager.load(PlugInManager.java:86) at com.vividsolutions.jump.workbench.JUMPWorkbench.main(JUMPWorkbench.java:361) at com.vividsolutions.jump.workbench.JUMPWorkbench.main(JUMPWorkbench.java:319) Michaël Le 01/09/2011 15:02, Matthias Scholz a écrit : > Hi, > > I've made a small improvement to some addMainMenuItem() methods of the > FeatureInstaller. In the past some of the methods gave a void and other > a JMenuItem back. Now all methods give the JMenuItem back. This is > usefull for some plugins, which have the needs to modify the menu items > text during runtime for example. > A change from a void return type to a JMenuItem should IMHO no problem > for the other code. > > regards > > Matthias > > ------------------------------------------------------------------------------ > Special Offer -- Download ArcSight Logger for FREE! > Finally, a world-class log management solution at an even better > price-free! And you'll get a free "Love Thy Logs" t-shirt when you > download Logger. Secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsisghtdev2dev > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > > ------------------------------------------------------------------------------ Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel