On 03.09.2011 21:16, Michaël Michaud wrote:
> Hi Matthias,
> 
> Thanks for taking care of code consistency (hard  work indeed).
> 
> I thought I would get no problem with the change you did in 
> FeatureInstaller, because return type is not part of method signature,

is it not? :)
 
> but I have to recompile extensions using FeatureInstaller (most of them) 
> tomake them work (see error message hereafter with a recent plugin which 
> has not been recompiled).
> I don't know why recompilation is required, but it's quite annoying that 
> all plugins compiled against OpenJUMP 1.4.1 or less do not work with 1.4.2+.

because the return type is part of the method definition, i'd say

> 
> The worst is that we cannot keep both methods to deprecate old ones 
> progressively as two methods with only a different return type cannot exist.
> 
> Any idea somebody ?

we should workaround that issue, let's revert the change and offer (if we do 
not already) a getMenuItem method for the same purpose. I know we use it 
already internally in the FeatureInstaller.

OR

create a new set of e.g. create(Main|Popup)MenuItem set with the proper return 
type and declare the old addMenuItem methods deprecated.

ede

------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better 
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to