Hi Matthias, a quick answer so you know we got it this time ;)
Thanks for your emails. We surely will check you patch and commit. (At least I first have to read again what #331 is was about.) If you think you keep contributing the svn write access rules are as follows: You would have to send two code contribution/patches (one you sent already). And if both are approved, then we could give you write access to the SVN. Alternatively, someone else who knows already your skills can speak up for you and we would give you straight write access (this happened too). I think these rules are a fairly low barrier, and we are always happy if someone is willing to contribute. Maybe just one question: Do you have previous experience with collaborative developments using (& committing) repositories (CSV, SVN or git)? However, I know people who worked/did research in Munster @Ifgi, so I am certainly sure that your contributions will be very valuable. Oh, and regarding your question from the first email: If you start working on a ticket/bug/feature, just make a short announcement on the list - to be safe. But it is really really rare that someone would work on the same thing. Also, if we add you to the svn for write access, we can also make you a project member (Do you want to be added right away?), which gives you the option to assign tickets to yourself. thanks again & Welcome...and lets see if we hear from Michael as well (currently the main developer, together with Ede). cheers, stefan Am 06.09.13 16:45, schrieb Matthias Hinz: > Dear List, > > I would like to contribute a solution for ticket #331. Because I made a > mistake with the Mailinglist, so my last two Emails did not reach you > unfortunately. (I subscribed with @googlemail.com and wrote emails with > @gmail.com) > The original messages are attached bellow. The first email is a quick > introduction of mine, the second explains what I developed till now. > > Best Regards, > Matthias > > -------- Original-Nachricht -------- > Betreff: #331 relative path name support > Datum: Fri, 06 Sep 2013 18:47:52 +0200 > Von: Matthias Hinz <matthias.m.h...@gmail.com> > An: OpenJump develop and use <jump-pilot-devel@lists.sourceforge.net> > > > > Dear List, > > according to ticket #331 [1] and the discussion on the user list [2], i > found a solution for the relative path name support. It is aimed to use > relative paths inside the jmp files for data sources located bellow the > project file. I am not yet sure if I am allowed to commit to the SVN, so > I created a patch file for you to review. I will do the commit if i get > the approval. > > I changed /AbstractSaveProjectPlugin/ and /OpenProjectWizzard/ for the > loading and saving of jmp files. > Basically, when the project is opened each layer is checked for relative > paths before oj tries to load them. They are replaced by absolute paths > based on the project file location. From then, everything works like it > did before (-> load layer, try to find broken files). Internally, OJ > still handles absolute paths so that no errors occur. > > When the project is saved, all absolute path names are replaced by > relative paths, if they are located bellow the project file (or in the > same directory). Because the task object gets manipulated and OJ > continues to use it, this step is /undone/ after the java2xml serialization. > This was a more handy solution than string-matching on xml file or > cloning the object and I hope it is intuitive. > > I tested my solution manually with the shapefile samples and some > jml-layers, that I created with oj. I moved the project file and saved > it in different locations with no errors. Projects from older versions > of oj can still be opened. On the other hand, errors arise newer > projects are opened by older versions of oj: Relative paths cannot be > found, because they are interpreted relative to the java work directory > and the file finder will throw an IndexOutOfBoundsException when > comparing the selected absolute path with the given relative path. So > new projects may not be downward-compatible. That may or may not be a > con for my solution (?) > > I'm looking forward to your feedback. > > Best Regards, > Matthias > > [1] http://sourceforge.net/p/jump-pilot/bugs/331/ > [2] https://groups.google.com/forum/#!topic/openjump-users/2WPu_wJtwgI > <https://groups.google.com/forum/#%21topic/openjump-users/2WPu_wJtwgI> > > > > > > -------- Original-Nachricht -------- > Betreff: start developing / ticket #331 > Datum: Tue, 27 Aug 2013 21:01:18 +0200 > Von: Matthias Hinz <matthias.m.h...@gmail.com> > An: OpenJump develop and use <jump-pilot-devel@lists.sourceforge.net> > > > > Dear List, > > I would like to start developing with OpenJump and I appreciate any help > for getting started. To introduce myself, I am a student for master of > geoinformatics from University of Münster, Germany. > > So far, I tried to get familiar with the source code and got it running > in Eclipse. Maven ans SVN are working fine as well, though I had some > dependency errors at first. I would like to work on bug #331 that is > currently discussed in the user-mailinglist. I got some good ideas about > how to implement that, already. > > So I got some general questions: > 1. If I want to work on a task, how do I let others know? There are at > least three ways I can think of: By "owning" a ticket, by telling so on > the developers list and by leaving a comment in the ticket-related > discussion. > > 2. How should I contribute my solutions. I'm familiar with SVN already, > but maybe you prefer to review patches first? > > Best Regards, > Matthias > > > > > > > > > ------------------------------------------------------------------------------ > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! > Discover the easy way to master current and previous Microsoft technologies > and advance your career. Get an incredible 1,500+ hours of step-by-step > tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk > > > > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
