Feature Requests item #1874212, was opened at 2008-01-18 00:28
Message generated for change (Comment added) made by henryju
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=497985&aid=1874212&group_id=61302

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core API
Group: Release 1.5
>Status: Closed
Priority: 5
Private: No
Submitted By: Mike C (mtc3bmtc3b)
Assigned to: Julien HENRY (henryju)
Summary: support multiple selects with same name

Initial Comment:
I have an HTML page that has multiple <select> boxes, all with the same name.  
Only one is visible (and enabled) at a given time.  I want to be able to select 
and option in the Nth one, like the clickLink() methods allow.  HtmlUnit has 
the appropriate methods to get all <select> boxes by name, so not too difficult 
to implement.  I've done so, and am attaching the patch built against the 
latest 1.5 release.  I only implemented it for HtmlUnit since I don't know 
Selenium.

I didn't add any tests for this, but I can if desired.  But, before I spend the 
time, I want to make sure this change is accepted.



----------------------------------------------------------------------

>Comment By: Julien HENRY (henryju)
Date: 2008-01-22 09:29

Message:
Logged In: YES 
user_id=1235926
Originator: NO

Patch apply.

Thanks.

I've also updated Clover2 licence.

----------------------------------------------------------------------

Comment By: Mike C (mtc3bmtc3b)
Date: 2008-01-21 21:50

Message:
Logged In: YES 
user_id=824259
Originator: YES

Okay, replacing the diff with a new one with tests added, no pom.xml, and
Selenium throwing exceptions.  I also expanded it to cover all option
related methods, not just the ones I needed for my site, and added some
additional JavaDocs.  The tests cover everything exposed by WebTester.  The
tests do not cover unselection of options since this is not exposed in
WebTester.  However, I did add the necessary methods to support indexes
into ITestingEngine if it is exposed in the future.

If there are any other changes I need to make, just let me know...
File Added: MultiSelect.patch

----------------------------------------------------------------------

Comment By: Mike (mtc3b)
Date: 2008-01-19 00:28

Message:
Logged In: YES 
user_id=1954039
Originator: NO

Yep, I can do all that.  I'll try to get to it this weekend. 

I had to modify pom.xml because I didn't have a Clover license and because
there is a bug in javacc on Windows that I needed to patch.  But, it
shouldn't have been in the patch I created for you.  I'll create a new one
with a test case and make sure it has the right files in it, with relative
paths.

----------------------------------------------------------------------

Comment By: Julien HENRY (henryju)
Date: 2008-01-18 09:04

Message:
Logged In: YES 
user_id=1235926
Originator: NO

Hi,

Thanks for this contribution. Could you please add at least one test case
with a simple page including 2 <select> with same name (ensure you can play
with both).

Also there are some minor fixes (but I can do it myself):
  - do not alter pom.xml
  - make no implemented Selenium methods throw an exception instead of
returning false
  - your patch should not contain full file paths but relative paths

Thanks


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=497985&aid=1874212&group_id=61302

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
JWebUnit-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jwebunit-development

Reply via email to