[
https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286737#comment-13286737
]
Jun Rao commented on KAFKA-349:
-------------------------------
Thanks for patch v6. Some new comments:
61. FetchResponse, ProducerResponse: VersionId should be the first item is
serialized data since we will be depending on VersionId to deserialize the
right version of the data in the future.
62. Could you rebase since trunk has moved?
63. The only test that fails for me is testCleanupExpiredSegments, which is
fixed as part of merging from trunk to 0.8. If you rebase, that test should
pass.
> Create individual "Response" types for each kind of request and wrap them
> with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests
> except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2,
> kafka_responseSend.patch.3, kafka_responseSend.patch.4,
> kafka_responseSend.patch.5, kafka_responseSend.patch.6
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
