[
https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289865#comment-13289865
]
Jun Rao commented on KAFKA-349:
-------------------------------
A few more comments for patch v8.
81. LeaderAndISRRequest and StopReplicaRequest: Could we add a default value
for versionId and clientId in the constructor (like in FetchRequest)?
82. ProducerResponse and OffsetResponse: remove val CurrentVersion.
> Create individual "Response" types for each kind of request and wrap them
> with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests
> except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2,
> kafka_responseSend.patch.3, kafka_responseSend.patch.4,
> kafka_responseSend.patch.5, kafka_responseSend.patch.6,
> kafka_responseSend.patch.7, kafka_responseSend.patch.8
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
