[ 
https://issues.apache.org/jira/browse/KAFKA-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399439#comment-13399439
 ] 

Jun Rao commented on KAFKA-306:
-------------------------------

Thanks for patch v4. A few more comments:

21.2 KAFA-313 adds 2 more options, which option does this jira depends on?

21.3 I meant that we should add mirror maker in the following line in the 
header:
# 5. One of the Kafka SOURCE or TARGET brokers in the cluster will
#    be randomly terminated and waiting for the consumer to catch up.

21.4 Instead of using checksum, can we use the message string itself? This 
makes it a bit easier to figure out the missing messages, if any.

22. Just attached a patch to kafka-370. Could you give it a try?

                
> broker failure system test broken on replication branch
> -------------------------------------------------------
>
>                 Key: KAFKA-306
>                 URL: https://issues.apache.org/jira/browse/KAFKA-306
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: John Fung
>              Labels: replication
>         Attachments: kafka-306-v1.patch, kafka-306-v2.patch, 
> kafka-306-v3.patch, kafka-306-v4.patch
>
>
> The system test in system_test/broker_failure is broken on the replication 
> branch. This test is a pretty useful failure injection test that exercises 
> the consumer rebalancing feature, various replication features like leader 
> election. It will be good to have this test fixed as well as run on every 
> checkin to the replication branch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to