[
https://issues.apache.org/jira/browse/KAFKA-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408271#comment-13408271
]
Joel Koshy commented on KAFKA-306:
----------------------------------
Thanks for making the changes - looks better.
> - This is because the values may be overridden later by user specified
> values. Therefore, some of the val is changed to var
I meant even with overrides I don't think you need these vars and they can
be handled better with vals. However, it's a minor issue and looking at
ProducerPerformance it seems it needs an overhaul - the main loop is pretty
hard to
read. We should probably do that in a separate jira as it isn't directly
related to this one.
BTW, it seems bytesSent is not updated in seqIdMode.
> broker failure system test broken on replication branch
> -------------------------------------------------------
>
> Key: KAFKA-306
> URL: https://issues.apache.org/jira/browse/KAFKA-306
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: John Fung
> Labels: replication
> Attachments: kafka-306-v1.patch, kafka-306-v2.patch,
> kafka-306-v3.patch, kafka-306-v4.patch, kafka-306-v5.patch,
> kafka-306-v6.patch, kafka-306-v7.patch, kafka-306-v8.patch
>
>
> The system test in system_test/broker_failure is broken on the replication
> branch. This test is a pretty useful failure injection test that exercises
> the consumer rebalancing feature, various replication features like leader
> election. It will be good to have this test fixed as well as run on every
> checkin to the replication branch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
