[
https://issues.apache.org/jira/browse/KAFKA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434603#comment-13434603
]
Jun Rao commented on KAFKA-356:
-------------------------------
Thanks for patch v2. Some comments:
1. KafkaThread:
1.1 Since this thread controls shutdown itself, it should always be a
non-daemon thread. So, we just need 1 construct that takes name and logindent.
The logindent can probably just to a string, instead of an option.
1.2 Can we rename fun() to something like doWork()?
2. ConsumerFetcherManager: remove unused imports
> Create a generic Kafka thread class that includes basic boiler plate code of
> instantiating and shutting down threads cleanly
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-356
> URL: https://issues.apache.org/jira/browse/KAFKA-356
> Project: Kafka
> Issue Type: Sub-task
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Yang Ye
> Labels: optimization
> Attachments: kafka_356_v1.diff, kafka_356_v2.diff
>
>
> We have a lot of threads that basically run in a loop and use an isRunning
> atomic boolean and count down latch. It will be useful to refactor it out
> into a helper runnable that these can extend. Verifying the lifecycle details
> for each is kind of a pain and it pretty easy to either not cleanly shutdown
> all the threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
