[
https://issues.apache.org/jira/browse/KAFKA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435377#comment-13435377
]
Yang Ye commented on KAFKA-356:
-------------------------------
Jay, thanks for the comments.
1. Yeah, as also commented by Jun
2. logIdent is a field inherited from the Thread class, which is printed out
first, then the log messages you specify. Say if you have logIdent "A class, "
and it says info("blabla") in your code, the actual log will be "A class,
blabla", this also answers comment 4, 5
3. Yeah I can, but it seems that in our whole project, we don't use scaladoc
syntaxes other than "/**, */": https://wiki.scala-lang.org/display/SW/Syntax,
so I won't use fancy syntaxes like bold, italic, link, etc.
6. I have thought about that, but neither BackgroundThread nor WorkerThread
carry much meaning. So what about "InterruptableThread"
7. I've changed it to doWork()
> Create a generic Kafka thread class that includes basic boiler plate code of
> instantiating and shutting down threads cleanly
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-356
> URL: https://issues.apache.org/jira/browse/KAFKA-356
> Project: Kafka
> Issue Type: Sub-task
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Yang Ye
> Labels: optimization
> Attachments: kafka_356_v1.diff, kafka_356_v2.diff
>
>
> We have a lot of threads that basically run in a loop and use an isRunning
> atomic boolean and count down latch. It will be useful to refactor it out
> into a helper runnable that these can extend. Verifying the lifecycle details
> for each is kind of a pain and it pretty easy to either not cleanly shutdown
> all the threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
