On Mon, Feb 9, 2015 at 9:37 PM, Sean Farley
<[email protected]> wrote:
>
> Nick Coghlan writes:
>
>> On 10 Feb 2015 04:33, "Jan Heylen" <[email protected]> wrote:
>>>
>>> On Mon, Feb 9, 2015 at 7:25 PM, Mads Kiilerich <[email protected]> wrote:
>>>
>>> >
>>> > I notice that PRs and comments pretty much corresponds to a 'forum'.
>> People
>>> > might have different policies for what they want to see, what they want
>> to
>>> > see again, what they don't care about, which follow-up comments they
>> want to
>>> > see, etc.
>>> >
>>> > It is on my todo-list to implement some 'this comment requires
>> follow-up'
>>> > functionality.
>>> That is true, but that is helpful in the review-EE his context, not in
>>> the review-ER his context.
>>
>> I think the forum analogy still holds, but in the "unread notifications"
>> sense.
>>
>> So you could flip the notion on its head and have PRs, and individual
>> threads within the PR marked as "unreviewed" by default, and then as you
>> view the files, they each get marked as read.
>>
>> That perspective gives a rich set of UX precedents to draw from - not just
>> the "reviewed" checkboxes in the Gerrit UI, but also the "automatically
>> mark as read" behaviour that is common in email clients and forum software.
>
> That's a nice suggestion.

I agree, and we can probably reuse the unread notifications framework
to keep track,

thx for the input, I'll give it some time to think through the technical part...

br,

Jan
_______________________________________________
kallithea-general mailing list
[email protected]
http://lists.sfconservancy.org/mailman/listinfo/kallithea-general

Reply via email to