This is a first part of e-mail setting related cleanup, as driven by the feedback on my other e-mail setting related changes. This series does not change behavior, but rather documents and changes display of information on the admin page.
This series, in particular the commit adding documentation to the .ini file, is assumed to solve issue #43 "Is email settings work fine?" which is believed to be a configuration problem. Note: ideally, the admin e-mail settings page would also show the defaults in use by Kallithea. At this moment, this means 'Kallithea' as subject prefix, and false/false for ssl/tls. To avoid duplicating the defaults again in that template, which is fragile, some refactoring would be needed. One idea is to create a dictionary with e-mail settings taken from the config file and falling back to defaults, all users of these settings should then use the dictionary rather than directly querying kallithea.CONFIG. Suggestions for a good location to store and populate such a dictionary, or another method to achieve the same goal, are very welcome. _______________________________________________ kallithea-general mailing list [email protected] http://lists.sfconservancy.org/mailman/listinfo/kallithea-general
