On Thu, Jul 23, 2015 at 2:14 PM, Mads Kiilerich <[email protected]> wrote: > On 07/22/2015 09:50 PM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire <[email protected]> >> # Date 1437509310 -7200 >> # Tue Jul 21 22:08:30 2015 +0200 >> # Node ID c8e5401db62afbfe417a35b10189bf85aff97726 >> # Parent 07fc479b91cef2b8f6240d1b64baabdf3caebdc0 >> admin: e-mail: display settings as read-only input fields >> >> Using a definition list to display the e-mail settings has following >> disadvantages: >> - different look&feel than the other admin settings, including the equally >> read-only hooks page >> - there are only two elements in a definition list (the item and its >> value) >> and it is therefore difficult to add more clarification about these >> items >> >> Instead, follow the same strategy as on the hooks page, showing each >> setting >> in a read-only text input field. > > > I think it is a bit confusing that these real-only values look so much like > the only actual input field on the same page. Why show it as an input field? > Thoughts? >
If we don't show any ini setting at all (see other discussion) then this will become irrelevant, but in any case I was following the same approach as the existing hooks page. I guess a side-reason is the fact that we can follow the existing styling rules of the admin UI, it all looks the same with no effort. But, I also understand your point. /Thomas _______________________________________________ kallithea-general mailing list [email protected] http://lists.sfconservancy.org/mailman/listinfo/kallithea-general
