Hi,

this is v2 patchset that makes simple diffs collapsable and it's default 
behaviour configurable.

Apparently the collapsing code was broken since a while, I reverted the change 
that broke it (just this part).

As said by Mads, I messed up testing of v1 of this patch, I did rebaseing and 
refactoring of the patch in a different source tree,
but forgot to switch the virtualenv, so I ended up testing the same 
un-refactored and unrebased tree all the time (without noticing :-s).
That is also the reason I didn't saw that upstream the collapsing code was 
broken since a while...

Sorry for the confusion, please review V2 of the patch, and as said before: 
the part where the default behavior is hardcoded in pull requests: 
I don't think this is pullable, but maybe if this is made a "setting".

So, the main purpose of putting this last part on the mailinglist is a RFC for 
the "settings" part.
Should and how should I make this configurable?

But please, do already take in the first 2 patches, if OK.

regards,

Jan
_______________________________________________
kallithea-general mailing list
[email protected]
http://lists.sfconservancy.org/mailman/listinfo/kallithea-general

Reply via email to