woops, wrong order of patches, wrong order in revset in command, "PATCH 3 of 3" is the first one :-s (and vice versa)
Sorry, Jan On Thu, Dec 24, 2015 at 9:32 PM, Jan Heylen <[email protected]> wrote: > # HG changeset patch > # User Jan Heylen <[email protected]> > # Date 1450988899 -3600 > # Thu Dec 24 21:28:19 2015 +0100 > # Node ID f306d394f56a447d11521596df6ed730fbca9709 > # Parent 8bc8366a6874640c73c20ce8ecfb596c0b4134db > collapse: getting target via .attr instead of .prop > > commit 3f017db297c4 has broken standard collapse/expand diff feature: > for some unknown reason, the target attribute cannot be retreived like this > with the .prop jquery function, so reverting it back to something that was > working (.attr). Apparently the original change was untested ;-) > > diff -r 8bc8366a6874 -r f306d394f56a kallithea/public/js/base.js > --- a/kallithea/public/js/base.js Fri Nov 27 01:48:09 2015 +0100 > +++ b/kallithea/public/js/base.js Thu Dec 24 21:28:19 2015 +0100 > @@ -1918,7 +1918,7 @@ > $(document).ready(function(){ > $('.diff-collapse-button').click(function(e) { > var $button = $(e.currentTarget); > - var $target = $('#' + $button.prop('target')); > + var $target = $('#' + $button.attr('target')); > if($target.hasClass('hidden')){ > $target.removeClass('hidden'); > $button.html("↑ {0} ↑".format(_TM['Collapse Diff'])); _______________________________________________ kallithea-general mailing list [email protected] http://lists.sfconservancy.org/mailman/listinfo/kallithea-general
