I figured out how to use mercurial patch queues to make keeping all this straight on my end. Attached patches fix the following issues:
1_selector_deregister_doc_fix - This patch corrects the Selector.py docstring to reflect the correct removeReader and friends API. Minor consistency change for newReader and friends as well. 2_udpng_shutdown_cleanup - This patch builds upon the previous one by fixing UDP_ng clients so that they correctly deregister with the selector and close their socket upon shutdown. 3_udpng_safe_bind - This patch puts some basic exception handling around the port binding operation. The clients are updated to check for binding success. This patch prevents unhandled exceptions when trying to bind to a port already in use by something else. tcpclient_delay_micro_optimize - This patch is not dependent on any others. It micro-optimizes some delay calculations to move a math operation out of the loop. tcpserver_safe_bind - This patch is not dependent on any others. It modifies the TCPServer to catch exceptions related to trying to bind to a port already in use by something else. Cheers, Steve On Sat, Mar 14, 2009 at 11:18 AM, Steve wrote: > > Michael, > > What is the best way for me to make code contributions? I have > a lot of changes that I am making to my local copy of Kamaelia to get > it to work. I understand you might prefer to fix the problems in a > different way than I do. And I'd usually prefer your fixes when you > have time to make them. But keeping track of all the changes is > getting to be a bear. > > I need to start keeping my changes in a VCS. Do you want to make a > branch in svn? Or if I host my changes on a public mercurial > site, can you pull the changes from there? > > Some examples of changes I've made locally: > - Update UPDng to send a remove message & close socket on disconnect > - fix Selector.py docs so remove message only includes socket > descriptor > - fix UPDng so safeBind traps exceptions and returns boolean success > - update UDPng to check success of binding > - fix TCPServer so it traps port binding exceptions > - micro-optimize tcp connection timeout to take delay math out of > loop > - micro-optimize tcp delay before connect to take math out of loop > > Cheers, > Steve --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "kamaelia" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/kamaelia?hl=en -~----------~----~----~----~------~----~------~--~---
1_selector_deregister_doc_fix.patch
Description: Binary data
2_udpng_shutdown_cleanup.patch
Description: Binary data
3_udpng_safe_bind.patch
Description: Binary data
tcpclient_delay_micro_optimize.patch
Description: Binary data
tcpserver_safe_bind.patch
Description: Binary data
