On Tue, 4 Dec 2001 11:13:46 -0500, Ghozlane Toumi <[EMAIL PROTECTED]> wrote: >On Monday 03 December 2001 20:13, Keith Owens wrote: >Could you take a look a the attached makefile.in , it's in alpha/kernel, for >2.4.16 , i'd welcome any comment, specificaly regarding the >"ifneq ($(CONFIG_ALPHA_EB64P)$(CONFIG_ALPHA_EB66),) >obj-y += sys_eb64p.o >endif" >translations and the like ...
Those translations are exactly right, the object is selected if any of the specified configs are true. >btw, is there a way to test rules correctness without booting and finding the >hard way if the link succeeded or not ? >does comparing nm output of vmlinuxes built with the old and new kbuild >sounds right, or am i smoking bad stuff ? nm can help but I prefer to write down what the link order should be from kbuild 2.4 then compare it against .tmp_vmlinux_order which says exactly what kbuild 2.5 will do. >expsyms(alpha_ksyms.o) > >select(head.o) > >select(entry.o traps.o process.o osf_sys.o irq.o irq_alpha.o > signal.o setup.o ptrace.o time.o semaphore.o alpha_ksyms.o Missing ')' above. > ># ># FIXME! ># These should be made conditional on the stuff that needs them! ># >select(irq_i8259.o irq_srm.o > es1888.o smc37c669.o smc37c93x.o ns87312.o) > >select(CONFIG_VGA_HOSE console.o) >select(CONFIG_SMP smp.o irq_smp.o) >select(CONFIG_PCI pci.o pci_iommu.o) >select(CONFIG_SRM_ENV srm_env.o) > >ifsel (CONFIG_ALPHA_GENERIC) >select( core_apecs.o core_cia.o core_irongate.o core_lca.o core_mcpcia.o > core_polaris.o core_t2.o core_tsunami.o core_titan.o > sys_alcor.o sys_cabriolet.o sys_dp264.o sys_eb64p.o sys_eiger.o > sys_jensen.o sys_miata.o sys_mikasa.o sys_nautilus.o sys_titan.o > sys_noritake.o sys_rawhide.o sys_ruffian.o sys_rx164.o > sys_sable.o sys_sio.o sys_sx164.o sys_takara.o sys_rx164.o > sys_wildfire.o core_wildfire.o irq_pyxis.o) >else > An alternative form that /might/ be better in the long run is - select(CONFIG_ALPHA_APECS core_apecs.o) select(CONFIG_ALPHA_GENERIC core_apecs.o) select(CONFIG_ALPHA_CIA core_cia.o) select(CONFIG_ALPHA_GENERIC core_cia.o) select(CONFIG_ALPHA_IRONGATE core_irongate.o) select(CONFIG_ALPHA_GENERIC core_irongate.o) Adding generic against each board type instead of a single big generic entry. It provides a strong hint to anybody adding a new board that they need to consider generic. Either way you have to duplicate the object name, but the latter format is much easier to verify for completeness. It will mean reordering the individual entries to match the generic list, to produce the same link order as the original big generic list. Looks good. _______________________________________________ kbuild-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/kbuild-devel
