On Thu, 20 Dec 2001 08:09:19 -0700, Tom Rini <[EMAIL PROTECTED]> wrote: >Okay. With the various patches Keith has posted (and using kbuild-2.4 >for vmlinux -> zImage), I've gotten two different boards compiled and >booted. These still have the various debugging statements in, but aside >from that does anyone see any problems/nits I should go and fix? (I also >left out the files I had to modify for relative includes for now).
Do you have to change the source code to handle relative includes? Unless you changed the kbuild 2.4 Makefiles as well, changing source will prevent the use of kbuild 2.4 after your patch is applied. I avoided changing source for kbuild 2.5 unless the change was also 2.4 compatible. You should be able to handle relative includes with extra cflags (and a lot of FIXME comments). >--- /dev/null Wed Dec 31 17:00:00 1969 >+++ arch/ppc/amiga/Makefile.in Mon Dec 17 15:14:19 2001 >@@ -0,0 +1,5 @@ >+expsyms(amiga_ksyms.o) >+ >+select(CONFIG_APUS config.o amiints.o cia.o time.o bootinfo.o amisound.o \ >+ chipram.o amiga_ksyms.o) No need to use trailing '\', unless they are raw make commands like CFLAGS +=. Pre-processor commands do not need continuation markers and they just look ugly. >--- /dev/null Wed Dec 31 17:00:00 1969 >+++ arch/ppc/kernel/Makefile.in Wed Dec 19 21:30:47 2001 >@@ -0,0 +1,70 @@ >+ifsel(CONFIG_PPC64BRIDGE) >+extra_aflags_all(-Wa-mppc64bridge) >+endif Should the extra aflags for ppc64bridge be set in Makefile.defs.config so they affect everything? Also those flags look wrong, I would expect -Wa,-mppc64bridge, not -Wa-mppc64bridge. >+ifsel(CONFIG_WALNUT) >+select(CONFIG_PCI galaxy_pci.o) >+endif select(CONFIG_PCI CONFIG_WALNUT galaxy_pci.o) >+ifsel(CONFIG_8xx) >+select(CONFIG_PCI qspan_pci.o) >+ifnsel(CONFIG_MATH_EMULATION) >+select(softemu8xx.o) >+endif >+endif select(CONFIG_8xx CONFIG_PCI qspan_pci.o) select(CONFIG_8xx !CONFIG_MATH_EMULATION softemu8xx.o) >+ifsel(CONFIG_APUS) >+select(CONFIG_PCI apus_pci.o) >+endif select(CONFIG_PCI CONFIG_APUS apus_pci.o) >+ifsel(CONFIG_SMP) >+select(CONFIG_ALL_PPC pmac_smp.o chrp_smp.o) >+endif select(CONFIG_ALL_PPC CONFIG_SMP pmac_smp.o chrp_smp.o) >--- /dev/null Wed Dec 31 17:00:00 1969 >+++ arch/ppc/math-emu/Makefile.in Mon Dec 17 14:59:17 2001 >@@ -0,0 +1,11 @@ >+select(math.o fmr.o lfd.o stfd.o) >+select(CONFIG_MATH_EMULATION fabs.o fadd.o fadds.o fcmpo.o fcmpu.o \ Remove trailing '\'. >--- /dev/null Wed Dec 31 17:00:00 1969 >+++ arch/ppc/xmon/Makefile.in Wed Dec 19 09:37:19 2001 >@@ -0,0 +1,6 @@ >+ifsel(CONFIG_8xx) >+ select(CONFIG_XMON start_8xx.o) >+else >+ select(CONFIG_XMON start.o) >+endif select(CONFIG_XMON CONFIG_8xx start_8xx.o) select(CONFIG_XMON !CONFIG_8xx start.o) _______________________________________________ kbuild-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/kbuild-devel
