On Fri, Dec 21, 2001 at 07:34:35AM +1100, Keith Owens wrote: > On Thu, 20 Dec 2001 08:09:19 -0700, > Tom Rini <[EMAIL PROTECTED]> wrote: > >Okay. With the various patches Keith has posted (and using kbuild-2.4 > >for vmlinux -> zImage), I've gotten two different boards compiled and > >booted. These still have the various debugging statements in, but aside > >from that does anyone see any problems/nits I should go and fix? (I also > >left out the files I had to modify for relative includes for now). > > Do you have to change the source code to handle relative includes? > Unless you changed the kbuild 2.4 Makefiles as well, changing source > will prevent the use of kbuild 2.4 after your patch is applied. I > avoided changing source for kbuild 2.5 unless the change was also 2.4 > compatible. You should be able to handle relative includes with extra > cflags (and a lot of FIXME comments).
Yeah, I did the 'proper' kbuild-2.5 only fix for now. What would the proper extra flag be for #include "../../../drivers/scsi/sd.h" tho? $(src_listinc /) or so? > >--- /dev/null Wed Dec 31 17:00:00 1969 > >+++ arch/ppc/amiga/Makefile.in Mon Dec 17 15:14:19 2001 > >@@ -0,0 +1,5 @@ > >+expsyms(amiga_ksyms.o) > >+ > >+select(CONFIG_APUS config.o amiints.o cia.o time.o bootinfo.o amisound.o \ > >+ chipram.o amiga_ksyms.o) > > No need to use trailing '\', unless they are raw make commands like > CFLAGS +=. Pre-processor commands do not need continuation markers and > they just look ugly. Ah, okay. > >--- /dev/null Wed Dec 31 17:00:00 1969 > >+++ arch/ppc/kernel/Makefile.in Wed Dec 19 21:30:47 2001 > >@@ -0,0 +1,70 @@ > >+ifsel(CONFIG_PPC64BRIDGE) > >+extra_aflags_all(-Wa-mppc64bridge) > >+endif > > Should the extra aflags for ppc64bridge be set in Makefile.defs.config > so they affect everything? Also those flags look wrong, I would expect > -Wa,-mppc64bridge, not -Wa-mppc64bridge. Yeah, that's a typo. Thanks. I'll ask the ppc64 people if all .S files should get it or what. > >+ifsel(CONFIG_WALNUT) > >+select(CONFIG_PCI galaxy_pci.o) > >+endif > > select(CONFIG_PCI CONFIG_WALNUT galaxy_pci.o) Yeah, that came out of pass-one (directish translation). I found the select(CONFIG_A ... CONFIG_N foo.o) later on. I'll go fix those bits and post a patch (are you planning on a 2.4.16-3 or going to wait until 2.4.17 is out?). -- Tom Rini (TR1265) http://gate.crashing.org/~trini/ _______________________________________________ kbuild-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/kbuild-devel
