On Mon, 13 May 2002 17:56:14 +0200, 
Arnd Bergmann <[EMAIL PROTECTED]> wrote:
>It seems you introduced a new bug by adding '-a' to cp as well as '-f', 
>causing the files to keep their owner after installation. If you do

Will be in core-14.

Index: 15.4/Makefile.in
--- 15.4/Makefile.in Sat, 11 May 2002 19:01:36 +1000 kaos (linux-2.5/M/e/27_Makefile.i 
1.6 644)
+++ 15.4(w)/Makefile.in Tue, 14 May 2002 09:14:43 +1000 kaos 
+(linux-2.5/M/e/27_Makefile.i 1.6 644)
@@ -385,7 +385,7 @@ modules_install: install_check
          rm -rf $(module_dir)kernel; \
          mkdir $(module_dir)kernel; \
          sed -e "s:^:$(module_dir)kernel/:" $(objfile .tmp_vmlinux_modules) | 
$(dirname) | sort | uniq | xargs -r mkdir -p; \
-         sed -e "s:\(.*\):cp -fa \1 $(module_dir)kernel/\1:" $(objfile 
.tmp_vmlinux_modules) | $(KBUILD_SHELL)
+         sed -e "s:\(.*\):cp \1 $(module_dir)kernel/\1:" $(objfile 
+.tmp_vmlinux_modules) | $(KBUILD_SHELL)
        @echo "  Running depmod, $(DEPMOD) -ae -F $(objfile System.map) $(depmod_opts) 
$(KERNELRELEASE)"
        $(KBUILD_QUIET)$(DEPMOD) -ae -F $(objfile System.map) $(depmod_opts) 
$(KERNELRELEASE)
 

>When testing this, I noticed that 'make install' did not rebuild
>the global makefile after I change /Makefile.in as root. It warns
>'Using existing global Makefile for install, writing is disabled when 
>installing as another user', but does not stop with 'KBUILD_WRITABLE is 
>false, giving up' as I expected. Is this correct?

It says 'Using existing global Makefile for install' so ignoring all
changes to config, Makefile.in, environment variables and the command
line during install is correct.  It is difficult to be 100% sure if any
change has affected the generated makfile or not, this is why I refuse
to optimize away the makefile generation when "nothing has changed".

OTOH, I can detect if some makefile associated data has changed at
install time and issue warnings.  What do people think, is it worth
checking for CML and makefile changes during install or is the message
"Using existing global Makefile for install" enough of a hint that CML
and makefile changes are ignored.  This is only a problem when building
as one user and installing as another, doing make oldconfig install all
as root does a full check.


_______________________________________________________________

Have big pipes? SourceForge.net is looking for download mirrors. We supply
the hardware. You get the recognition. Email Us: [EMAIL PROTECTED]
_______________________________________________
kbuild-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/kbuild-devel

Reply via email to