On Sun, 3 Nov 2002, Peter Samuelson wrote: > With !KBUILD_VERBOSE output, you can't tell whether a CC or LD line is > for a module or for the kernel proper. Sure, most people probably > don't care, but *I* do. Hence this patch. Output: > > CC vmlinux-object.o > CC [M] standalone-module.o > CC (M) partial-module.o > LD built-in.o > LD [M] composite-object.o
This looks generally looks okay to me, I don't like the subtle difference between stand-alone and partial module, though, probably nobody can remember that, anyway ;) And there is really no difference in the command line, so why print something different. The LD line also doesn't really depend on whether we're linking a module or not, so not sure about the [M] there. If anything, I'd suggest to have it there for a composite object which is linked to become a module, and not there for a composite object which is linked into the kernel / built-in.o. I think your patch does the latter, so my point is only about the CC (M)/[M]. Also, implementation-wise, it may be cleaner to handle things the same way '-DMODULE' gets added? Does that make sense? --Kai ------------------------------------------------------- This SF.net email is sponsored by: ApacheCon, November 18-21 in Las Vegas (supported by COMDEX), the only Apache event to be fully supported by the ASF. http://www.apachecon.com _______________________________________________ kbuild-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/kbuild-devel
