I reported this one earlier. regards, dan carpenter
On Thu, Nov 13, 2014 at 04:24:12PM +0800, kbuild test robot wrote: > TO: Mark Brown <[email protected]> > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > master > head: bbdef57970d5e1887de755474ff1562baa17ef11 > commit: 9169051617df7fca597274e9e43324332cb8f0ee [5753/6487] spi: spidev: > Don't mangle max_speed_hz in underlying spi device > :::::: branch date: 80 minutes ago > :::::: commit date: 2 days ago > > drivers/spi/spidev.c:583 spidev_release() warn: variable dereferenced before > check 'spidev->spi' (see line 579) > > git remote add next > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git remote update next > git checkout 9169051617df7fca597274e9e43324332cb8f0ee > vim +583 drivers/spi/spidev.c > > 865f6d19 Ray Jui 2014-10-09 573 > kfree(spidev->tx_buffer); > 865f6d19 Ray Jui 2014-10-09 574 spidev->tx_buffer = > NULL; > 865f6d19 Ray Jui 2014-10-09 575 > 865f6d19 Ray Jui 2014-10-09 576 > kfree(spidev->rx_buffer); > 865f6d19 Ray Jui 2014-10-09 577 spidev->rx_buffer = > NULL; > b2c8dadd David Brownell 2008-06-05 578 > 91690516 Mark Brown 2014-11-08 @579 spidev->speed_hz = > spidev->spi->max_speed_hz; > 91690516 Mark Brown 2014-11-08 580 > b2c8dadd David Brownell 2008-06-05 581 /* ... after we unbound > from the underlying device? */ > b2c8dadd David Brownell 2008-06-05 582 > spin_lock_irq(&spidev->spi_lock); > b2c8dadd David Brownell 2008-06-05 @583 dofree = (spidev->spi > == NULL); > b2c8dadd David Brownell 2008-06-05 584 > spin_unlock_irq(&spidev->spi_lock); > b2c8dadd David Brownell 2008-06-05 585 > b2c8dadd David Brownell 2008-06-05 586 if (dofree) > > :::::: The code at line 583 was first introduced by commit > :::::: b2c8daddcbe03a22402ecf943bb88302601c6835 spi: fix refcount-related > spidev oops-on-rmmod > > :::::: TO: David Brownell <[email protected]> > :::::: CC: Linus Torvalds <[email protected]> > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > http://lists.01.org/mailman/listinfo/kbuild Intel Corporation _______________________________________________ kbuild mailing list [email protected] https://lists.01.org/mailman/listinfo/kbuild
