CC: [email protected] In-Reply-To: <[email protected]> References: <[email protected]> TO: Oleksij Rempel <[email protected]> TO: Andrew Lunn <[email protected]> TO: "David S. Miller" <[email protected]> CC: [email protected] TO: Florian Fainelli <[email protected]> TO: Heiner Kallweit <[email protected]> TO: Jakub Kicinski <[email protected]> TO: Jonathan Corbet <[email protected]> TO: Michal Kubecek <[email protected]> TO: Oleksij Rempel <[email protected]> TO: David Jander <[email protected]> TO: [email protected] TO: [email protected] TO: [email protected] TO: Russell King <[email protected]> TO: [email protected] TO: Oleksij Rempel <[email protected]> TO: David Jander <[email protected]> TO: [email protected] TO: [email protected] TO: [email protected] TO: Russell King <[email protected]> TO: [email protected] CC: Oleksij Rempel <[email protected]> CC: David Jander <[email protected]> CC: [email protected] CC: [email protected] CC: [email protected] CC: Russell King <[email protected]>
Hi Oleksij, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on net/master linus/master v5.7-rc1 next-20200415] [cannot apply to sparc-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Oleksij-Rempel/ethtool-provide-UAPI-for-PHY-master-slave-configuration/20200416-035217 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 7f80ccfe996871ca69648efee74a60ae7ad0dcd9 :::::: branch date: 2 hours ago :::::: commit date: 2 hours ago If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/net/phy/phy_device.c:1812 genphy_read_master_slave() warn: impossible condition '(ctl < 0) => (0-u16max < 0)' drivers/net/phy/phy_device.c:1816 genphy_read_master_slave() warn: impossible condition '(stat < 0) => (0-u16max < 0)' Old smatch warnings: drivers/net/phy/phy_device.c:2521 phy_probe() warn: inconsistent indenting # https://github.com/0day-ci/linux/commit/effcba6cc15a16b619237177fed9bd60c5fa5b82 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout effcba6cc15a16b619237177fed9bd60c5fa5b82 vim +1812 drivers/net/phy/phy_device.c effcba6cc15a16 Oleksij Rempel 2020-04-15 1803 effcba6cc15a16 Oleksij Rempel 2020-04-15 1804 static int genphy_read_master_slave(struct phy_device *phydev) effcba6cc15a16 Oleksij Rempel 2020-04-15 1805 { effcba6cc15a16 Oleksij Rempel 2020-04-15 1806 u16 ctl, stat; effcba6cc15a16 Oleksij Rempel 2020-04-15 1807 effcba6cc15a16 Oleksij Rempel 2020-04-15 1808 if (!phydev->is_gigabit_capable) effcba6cc15a16 Oleksij Rempel 2020-04-15 1809 return 0; effcba6cc15a16 Oleksij Rempel 2020-04-15 1810 effcba6cc15a16 Oleksij Rempel 2020-04-15 1811 ctl = phy_read(phydev, MII_CTRL1000); effcba6cc15a16 Oleksij Rempel 2020-04-15 @1812 if (ctl < 0) effcba6cc15a16 Oleksij Rempel 2020-04-15 1813 return ctl; effcba6cc15a16 Oleksij Rempel 2020-04-15 1814 effcba6cc15a16 Oleksij Rempel 2020-04-15 1815 stat = phy_read(phydev, MII_STAT1000); effcba6cc15a16 Oleksij Rempel 2020-04-15 @1816 if (stat < 0) effcba6cc15a16 Oleksij Rempel 2020-04-15 1817 return stat; effcba6cc15a16 Oleksij Rempel 2020-04-15 1818 effcba6cc15a16 Oleksij Rempel 2020-04-15 1819 if (ctl & CTL1000_ENABLE_MASTER) { effcba6cc15a16 Oleksij Rempel 2020-04-15 1820 if (stat & LPA_1000MSRES) effcba6cc15a16 Oleksij Rempel 2020-04-15 1821 phydev->master_slave = PORT_MODE_MASTER_FORCE; effcba6cc15a16 Oleksij Rempel 2020-04-15 1822 else effcba6cc15a16 Oleksij Rempel 2020-04-15 1823 phydev->master_slave = PORT_MODE_SLAVE_FORCE; effcba6cc15a16 Oleksij Rempel 2020-04-15 1824 } else { effcba6cc15a16 Oleksij Rempel 2020-04-15 1825 if (stat & LPA_1000MSRES) effcba6cc15a16 Oleksij Rempel 2020-04-15 1826 phydev->master_slave = PORT_MODE_MASTER; effcba6cc15a16 Oleksij Rempel 2020-04-15 1827 else effcba6cc15a16 Oleksij Rempel 2020-04-15 1828 phydev->master_slave = PORT_MODE_SLAVE; effcba6cc15a16 Oleksij Rempel 2020-04-15 1829 } effcba6cc15a16 Oleksij Rempel 2020-04-15 1830 effcba6cc15a16 Oleksij Rempel 2020-04-15 1831 return 0; effcba6cc15a16 Oleksij Rempel 2020-04-15 1832 } effcba6cc15a16 Oleksij Rempel 2020-04-15 1833 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
