CC: [email protected] TO: Daniel Vetter <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: ac935d22736659be734251247dcc6f444fb98972 commit: fe5b7c86d6068ac33df2d46cf3c7a1859c3b84a8 [759/2366] drm/udl: Drop explicit drm_mode_config_cleanup call :::::: branch date: 25 hours ago :::::: commit date: 3 weeks ago If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <[email protected]> cppcheck warnings: (new ones prefixed by >>) drivers/gpu/drm/udl/udl_modeset.c:333:6: warning: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment] ret = 0; ^ drivers/gpu/drm/udl/udl_modeset.c:328:7: note: ret is assigned ret = udl_submit_urb(dev, urb, len); ^ drivers/gpu/drm/udl/udl_modeset.c:333:6: note: ret is overwritten ret = 0; ^ >> drivers/gpu/drm/udl/udl_modeset.c:490:15: warning: Redundant initialization >> for 'format_count'. The initialized value is overwritten before it is read. >> [redundantInitialization] format_count = ARRAY_SIZE(udl_simple_display_pipe_formats); ^ drivers/gpu/drm/udl/udl_modeset.c:466:22: note: format_count is initialized size_t format_count = ARRAY_SIZE(udl_simple_display_pipe_formats); ^ drivers/gpu/drm/udl/udl_modeset.c:490:15: note: format_count is overwritten format_count = ARRAY_SIZE(udl_simple_display_pipe_formats); ^ # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=fe5b7c86d6068ac33df2d46cf3c7a1859c3b84a8 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git remote update linux-next git checkout fe5b7c86d6068ac33df2d46cf3c7a1859c3b84a8 vim +/format_count +490 drivers/gpu/drm/udl/udl_modeset.c 5320918b9a87865 Dave Airlie 2010-12-15 463 5320918b9a87865 Dave Airlie 2010-12-15 464 int udl_modeset_init(struct drm_device *dev) 5320918b9a87865 Dave Airlie 2010-12-15 465 { 9fda81e00e060e3 Thomas Zimmermann 2019-12-10 466 size_t format_count = ARRAY_SIZE(udl_simple_display_pipe_formats); 9fda81e00e060e3 Thomas Zimmermann 2019-12-10 467 struct udl_device *udl = dev->dev_private; e829cf0b30b4b55 Thomas Zimmermann 2019-12-10 468 struct drm_connector *connector; e829cf0b30b4b55 Thomas Zimmermann 2019-12-10 469 int ret; e829cf0b30b4b55 Thomas Zimmermann 2019-12-10 470 fe5b7c86d6068ac Daniel Vetter 2020-03-23 471 ret = drmm_mode_config_init(dev); fe5b7c86d6068ac Daniel Vetter 2020-03-23 472 if (ret) fe5b7c86d6068ac Daniel Vetter 2020-03-23 473 return ret; 5320918b9a87865 Dave Airlie 2010-12-15 474 5320918b9a87865 Dave Airlie 2010-12-15 475 dev->mode_config.min_width = 640; 5320918b9a87865 Dave Airlie 2010-12-15 476 dev->mode_config.min_height = 480; 5320918b9a87865 Dave Airlie 2010-12-15 477 5320918b9a87865 Dave Airlie 2010-12-15 478 dev->mode_config.max_width = 2048; 5320918b9a87865 Dave Airlie 2010-12-15 479 dev->mode_config.max_height = 2048; 5320918b9a87865 Dave Airlie 2010-12-15 480 5320918b9a87865 Dave Airlie 2010-12-15 481 dev->mode_config.prefer_shadow = 0; d8177841aa8a5d3 Thomas Zimmermann 2019-12-10 482 dev->mode_config.preferred_depth = 16; 5320918b9a87865 Dave Airlie 2010-12-15 483 e6ecefaadfcdb03 Laurent Pinchart 2012-05-17 484 dev->mode_config.funcs = &udl_mode_funcs; 5320918b9a87865 Dave Airlie 2010-12-15 485 e829cf0b30b4b55 Thomas Zimmermann 2019-12-10 486 connector = udl_connector_init(dev); fe5b7c86d6068ac Daniel Vetter 2020-03-23 487 if (IS_ERR(connector)) fe5b7c86d6068ac Daniel Vetter 2020-03-23 488 return PTR_ERR(connector); e829cf0b30b4b55 Thomas Zimmermann 2019-12-10 489 9fda81e00e060e3 Thomas Zimmermann 2019-12-10 @490 format_count = ARRAY_SIZE(udl_simple_display_pipe_formats); :::::: The code at line 490 was first introduced by commit :::::: 9fda81e00e060e3ab9a56d77552d2d5e296f1007 drm/udl: Convert to struct drm_simple_display_pipe :::::: TO: Thomas Zimmermann <[email protected]> :::::: CC: Thomas Zimmermann <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected] _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
