CC: [email protected] TO: Denis Efremov <[email protected]> CC: Julia Lawall <[email protected]> CC: "James E.J. Bottomley" <[email protected]> CC: "Martin K. Petersen" <[email protected]> CC: Mauro Carvalho Chehab <[email protected]> CC: [email protected] CC: [email protected] CC: [email protected]
From: kernel test robot <[email protected]> drivers/scsi/arcmsr/arcmsr_attr.c:164:58-59: WARNING opportunity for kobj_to_dev() drivers/scsi/arcmsr/arcmsr_attr.c:69:58-59: WARNING opportunity for kobj_to_dev() drivers/scsi/arcmsr/arcmsr_attr.c:116:58-59: WARNING opportunity for kobj_to_dev() Use kobj_to_dev() instead of container_of() Generated by: scripts/coccinelle/api/kobj_to_dev.cocci Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") CC: Denis Efremov <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10 head: a2fc3718bc22e85378085568ecc5765fb28cabce commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/3] coccinelle: api: add kobj_to_dev.cocci script :::::: branch date: 5 days ago :::::: commit date: 5 days ago Please take the patch only if it's a positive warning. Thanks! arcmsr_attr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/scsi/arcmsr/arcmsr_attr.c +++ b/drivers/scsi/arcmsr/arcmsr_attr.c @@ -66,7 +66,7 @@ static ssize_t arcmsr_sysfs_iop_message_ char *buf, loff_t off, size_t count) { - struct device *dev = container_of(kobj,struct device,kobj); + struct device *dev = kobj_to_dev(kobj); struct Scsi_Host *host = class_to_shost(dev); struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata; uint8_t *ptmpQbuffer; @@ -113,7 +113,7 @@ static ssize_t arcmsr_sysfs_iop_message_ char *buf, loff_t off, size_t count) { - struct device *dev = container_of(kobj,struct device,kobj); + struct device *dev = kobj_to_dev(kobj); struct Scsi_Host *host = class_to_shost(dev); struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata; int32_t user_len, cnt2end; @@ -161,7 +161,7 @@ static ssize_t arcmsr_sysfs_iop_message_ char *buf, loff_t off, size_t count) { - struct device *dev = container_of(kobj,struct device,kobj); + struct device *dev = kobj_to_dev(kobj); struct Scsi_Host *host = class_to_shost(dev); struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata; uint8_t *pQbuffer; _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
