CC: [email protected] TO: Denis Efremov <[email protected]> CC: Julia Lawall <[email protected]> CC: Adam Radford <[email protected]> CC: "James E.J. Bottomley" <[email protected]> CC: "Martin K. Petersen" <[email protected]> CC: [email protected] CC: [email protected]
From: kernel test robot <[email protected]> drivers/scsi/3w-sas.c:102:60-61: WARNING opportunity for kobj_to_dev() drivers/scsi/3w-sas.c:133:60-61: WARNING opportunity for kobj_to_dev() Use kobj_to_dev() instead of container_of() Generated by: scripts/coccinelle/api/kobj_to_dev.cocci Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") CC: Denis Efremov <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10 head: a2fc3718bc22e85378085568ecc5765fb28cabce commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/3] coccinelle: api: add kobj_to_dev.cocci script :::::: branch date: 5 days ago :::::: commit date: 5 days ago Please take the patch only if it's a positive warning. Thanks! 3w-sas.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/3w-sas.c +++ b/drivers/scsi/3w-sas.c @@ -99,7 +99,7 @@ static ssize_t twl_sysfs_aen_read(struct struct bin_attribute *bin_attr, char *outbuf, loff_t offset, size_t count) { - struct device *dev = container_of(kobj, struct device, kobj); + struct device *dev = kobj_to_dev(kobj); struct Scsi_Host *shost = class_to_shost(dev); TW_Device_Extension *tw_dev = (TW_Device_Extension *)shost->hostdata; unsigned long flags = 0; @@ -130,7 +130,7 @@ static ssize_t twl_sysfs_compat_info(str struct bin_attribute *bin_attr, char *outbuf, loff_t offset, size_t count) { - struct device *dev = container_of(kobj, struct device, kobj); + struct device *dev = kobj_to_dev(kobj); struct Scsi_Host *shost = class_to_shost(dev); TW_Device_Extension *tw_dev = (TW_Device_Extension *)shost->hostdata; unsigned long flags = 0; _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
