CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: FelixCuioc <[email protected]>
TO: Joerg Roedel <[email protected]>
TO: [email protected]
TO: [email protected]
TO: David Woodhouse <[email protected]>
TO: Lu Baolu <[email protected]>
TO: Dan Carpenter <[email protected]>
TO: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

Hi FelixCuioc,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on iommu/next]
[also build test WARNING on linux/master linus/master v5.9-rc2 next-20200827]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/FelixCuioc/Add-support-for-ACPI-device-in-RMRR/20200827-180343
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
:::::: branch date: 8 hours ago
:::::: commit date: 8 hours ago
config: x86_64-randconfig-m001-20200827 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

New smatch warnings:
drivers/iommu/intel/dmar.c:748 dmar_acpi_bus_add_dev() error: uninitialized 
symbol 'ret'.

Old smatch warnings:
drivers/iommu/intel/dmar.c:1535 dmar_disable_qi() warn: this loop depends on 
readl() succeeding
drivers/iommu/intel/dmar.c:1535 dmar_disable_qi() warn: this loop depends on 
readl() succeeding
drivers/iommu/intel/dmar.c:1901 dmar_fault() warn: this loop depends on readl() 
succeeding
drivers/iommu/intel/dmar.c:2052 dmar_detect_dsm() warn: should '1 << func' be a 
64 bit type?

# 
https://github.com/0day-ci/linux/commit/555ce9fc47afc28756822855a8d45211bb6a39bb
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review 
FelixCuioc/Add-support-for-ACPI-device-in-RMRR/20200827-180343
git checkout 555ce9fc47afc28756822855a8d45211bb6a39bb
vim +/ret +748 drivers/iommu/intel/dmar.c

555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  731  
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  732  
static int dmar_acpi_bus_add_dev(u8 device_number, struct acpi_device *adev)
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  733  {
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  734       
struct dmar_drhd_unit *dmaru;
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  735       
struct acpi_dmar_hardware_unit *drhd;
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  736       
int ret;
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  737  
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  738       
for_each_drhd_unit(dmaru) {
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  739       
        drhd = container_of(dmaru->hdr,
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  740       
                            struct acpi_dmar_hardware_unit,
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  741       
                            header);
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  742       
        ret = dmar_acpi_insert_dev_scope(device_number, adev, (void *)(drhd+1),
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  743       
                                        ((void *)drhd)+drhd->header.length,
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  744       
                                        dmaru->devices, dmaru->devices_cnt);
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  745       
        if (ret)
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  746       
                break;
ed40356b5fcf1c drivers/iommu/dmar.c       David Woodhouse 2014-03-07  747       
}
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27 @748       
if (ret > 0)
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  749       
        ret = dmar_rmrr_add_acpi_dev(device_number, adev);
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  750  
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  751       
return ret;
555ce9fc47afc2 drivers/iommu/intel/dmar.c FelixCuioc      2020-08-27  752  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to