CC: [email protected] TO: Alexander Levin <[email protected]>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-5.4 head: bb0c18f726150f446238a46800665d16b1fc718b commit: 19289c2bceec65a4f5424e32409c06390ec6a06a [97/98] cpufreq: intel_pstate: Fix EPP setting via sysfs in active mode :::::: branch date: 5 hours ago :::::: commit date: 5 hours ago config: x86_64-randconfig-s022-20200828 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-191-g10164920-dirty git checkout 19289c2bceec65a4f5424e32409c06390ec6a06a # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> sparse warnings: (new ones prefixed by >>) >> drivers/cpufreq/intel_pstate.c:677:1: sparse: sparse: unused label >> 'return_pref' drivers/cpufreq/intel_pstate.c:2669:64: sparse: sparse: Using plain integer as NULL pointer drivers/cpufreq/intel_pstate.c:2670:64: sparse: sparse: Using plain integer as NULL pointer drivers/cpufreq/intel_pstate.c:2671:64: sparse: sparse: Using plain integer as NULL pointer drivers/cpufreq/intel_pstate.c:2672:64: sparse: sparse: Using plain integer as NULL pointer drivers/cpufreq/intel_pstate.c:2673:64: sparse: sparse: Using plain integer as NULL pointer drivers/cpufreq/intel_pstate.c:2674:64: sparse: sparse: Using plain integer as NULL pointer drivers/cpufreq/intel_pstate.c:2675:64: sparse: sparse: Using plain integer as NULL pointer drivers/cpufreq/intel_pstate.c:2676:64: sparse: sparse: Using plain integer as NULL pointer drivers/cpufreq/intel_pstate.c:2677:64: sparse: sparse: Using plain integer as NULL pointer drivers/cpufreq/intel_pstate.c:2678:64: sparse: sparse: Using plain integer as NULL pointer drivers/cpufreq/intel_pstate.c:2679:64: sparse: sparse: Using plain integer as NULL pointer drivers/cpufreq/intel_pstate.c:2680:64: sparse: sparse: Using plain integer as NULL pointer drivers/cpufreq/intel_pstate.c:2681:64: sparse: sparse: Using plain integer as NULL pointer drivers/cpufreq/intel_pstate.c:2682:64: sparse: sparse: Using plain integer as NULL pointer drivers/cpufreq/intel_pstate.c:2683:64: sparse: sparse: Using plain integer as NULL pointer # https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/commit/?id=19289c2bceec65a4f5424e32409c06390ec6a06a git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git git fetch --no-tags sashal-linux-stable queue-5.4 git checkout 19289c2bceec65a4f5424e32409c06390ec6a06a vim +/return_pref +677 drivers/cpufreq/intel_pstate.c 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 639 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 640 static int intel_pstate_set_energy_pref_index(struct cpudata *cpu_data, 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 641 int pref_index) 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 642 { 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 643 int epp = -EINVAL; 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 644 int ret; 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 645 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 646 if (!pref_index) 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 647 epp = cpu_data->epp_default; 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 648 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 649 mutex_lock(&intel_pstate_limits_lock); 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 650 108ec36b699475 Borislav Petkov 2019-03-30 651 if (boot_cpu_has(X86_FEATURE_HWP_EPP)) { 19289c2bceec65 Rafael J. Wysocki 2020-07-28 652 /* 19289c2bceec65 Rafael J. Wysocki 2020-07-28 653 * Use the cached HWP Request MSR value, because the register 19289c2bceec65 Rafael J. Wysocki 2020-07-28 654 * itself may be updated by intel_pstate_hwp_boost_up() or 19289c2bceec65 Rafael J. Wysocki 2020-07-28 655 * intel_pstate_hwp_boost_down() at any time. 19289c2bceec65 Rafael J. Wysocki 2020-07-28 656 */ 19289c2bceec65 Rafael J. Wysocki 2020-07-28 657 u64 value = READ_ONCE(cpu_data->hwp_req_cached); 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 658 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 659 value &= ~GENMASK_ULL(31, 24); 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 660 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 661 if (epp == -EINVAL) 3cedbc5a6d7f7c Len Brown 2017-05-01 662 epp = epp_values[pref_index - 1]; 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 663 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 664 value |= (u64)epp << 24; 19289c2bceec65 Rafael J. Wysocki 2020-07-28 665 /* 19289c2bceec65 Rafael J. Wysocki 2020-07-28 666 * The only other updater of hwp_req_cached in the active mode, 19289c2bceec65 Rafael J. Wysocki 2020-07-28 667 * intel_pstate_hwp_set(), is called under the same lock as this 19289c2bceec65 Rafael J. Wysocki 2020-07-28 668 * function, so it cannot run in parallel with the update below. 19289c2bceec65 Rafael J. Wysocki 2020-07-28 669 */ 19289c2bceec65 Rafael J. Wysocki 2020-07-28 670 WRITE_ONCE(cpu_data->hwp_req_cached, value); 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 671 ret = wrmsrl_on_cpu(cpu_data->cpu, MSR_HWP_REQUEST, value); 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 672 } else { 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 673 if (epp == -EINVAL) 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 674 epp = (pref_index - 1) << 2; 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 675 ret = intel_pstate_set_epb(cpu_data->cpu, epp); 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 676 } 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 @677 return_pref: 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 678 mutex_unlock(&intel_pstate_limits_lock); 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 679 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 680 return ret; 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 681 } 984edbdccc6ff0 Srinivas Pandruvada 2016-12-06 682 :::::: The code at line 677 was first introduced by commit :::::: 984edbdccc6ff01b953492f72296685ce3ea2497 cpufreq: intel_pstate: Support for energy performance hints with HWP :::::: TO: Srinivas Pandruvada <[email protected]> :::::: CC: Rafael J. Wysocki <[email protected]> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
