CC: [email protected]
In-Reply-To: 
<9b5902665dcc4c0fca7546987303e348d8657f59.1626383424.git.apark0...@student.cerritos.edu>
References: 
<9b5902665dcc4c0fca7546987303e348d8657f59.1626383424.git.apark0...@student.cerritos.edu>
TO: Amy Parker <[email protected]>
TO: [email protected]
CC: Amy Parker <[email protected]>
CC: [email protected]
CC: [email protected]

Hi Amy,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.14-rc1 next-20210716]
[cannot apply to pavel-linux-leds/for-next wireless-drivers-next/master 
wireless-drivers/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Amy-Parker/leds-change-led_brightness-definition-from-enum-to-typedef/20210716-052140
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
dd9c7df94c1b23feacd54112f33ad95d93f64533
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: x86_64-randconfig-m001-20210718 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>

smatch warnings:
drivers/platform/chrome/cros_kbd_led_backlight.c:53 
keyboard_led_get_brightness() warn: signedness bug returning '(-5)'
drivers/platform/x86/samsung-laptop.c:1124 kbd_led_set() warn: impossible 
condition '(value < 0) => (0-255 < 0)'

vim +53 drivers/platform/chrome/cros_kbd_led_backlight.c

492ef7829d2d09 Simon Que  2016-03-08  41  
b14a971f104520 Amy Parker 2021-07-15  42  static led_brightness
492ef7829d2d09 Simon Que  2016-03-08  43  keyboard_led_get_brightness(struct 
led_classdev *cdev)
492ef7829d2d09 Simon Que  2016-03-08  44  {
492ef7829d2d09 Simon Que  2016-03-08  45        unsigned long long brightness;
492ef7829d2d09 Simon Que  2016-03-08  46        acpi_status status;
492ef7829d2d09 Simon Que  2016-03-08  47  
492ef7829d2d09 Simon Que  2016-03-08  48        status = 
acpi_evaluate_integer(NULL, ACPI_KEYBOARD_BACKLIGHT_READ,
492ef7829d2d09 Simon Que  2016-03-08  49                                       
NULL, &brightness);
492ef7829d2d09 Simon Que  2016-03-08  50        if (ACPI_FAILURE(status)) {
492ef7829d2d09 Simon Que  2016-03-08  51                dev_err(cdev->dev, 
"Error getting keyboard LED value: %d\n",
492ef7829d2d09 Simon Que  2016-03-08  52                        status);
492ef7829d2d09 Simon Que  2016-03-08 @53                return -EIO;
492ef7829d2d09 Simon Que  2016-03-08  54        }
492ef7829d2d09 Simon Que  2016-03-08  55  
492ef7829d2d09 Simon Que  2016-03-08  56        return brightness;
492ef7829d2d09 Simon Que  2016-03-08  57  }
492ef7829d2d09 Simon Que  2016-03-08  58  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kbuild mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to