CC: [email protected] In-Reply-To: <2c51fa594245c3396400617caa686b8bf0887d16.1627990337.git.vilhelm.g...@gmail.com> References: <2c51fa594245c3396400617caa686b8bf0887d16.1627990337.git.vilhelm.g...@gmail.com> TO: William Breathitt Gray <[email protected]>
From: kernel test robot <[email protected]> drivers/counter/counter-chrdev.c:370:8-24: WARNING: counter_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. Generated by: scripts/coccinelle/api/stream_open.cocci CC: William Breathitt Gray <[email protected]> Reported-by: kernel test robot <[email protected]> Signed-off-by: kernel test robot <[email protected]> --- url: https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Introduce-the-Counter-character-device-interface/20210803-201000 base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next :::::: branch date: 4 hours ago :::::: commit date: 4 hours ago Please take the patch only if it's a positive warning. Thanks! counter-chrdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/counter/counter-chrdev.c +++ b/drivers/counter/counter-chrdev.c @@ -367,7 +367,7 @@ static int counter_chrdev_open(struct in get_device(&counter->dev); filp->private_data = counter; - return nonseekable_open(inode, filp); + return stream_open(inode, filp); } static int counter_chrdev_release(struct inode *inode, struct file *filp) _______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
