CC: [email protected] In-Reply-To: <2c51fa594245c3396400617caa686b8bf0887d16.1627990337.git.vilhelm.g...@gmail.com> References: <2c51fa594245c3396400617caa686b8bf0887d16.1627990337.git.vilhelm.g...@gmail.com> TO: William Breathitt Gray <[email protected]>
Hi William, I love your patch! Perhaps something to improve: [auto build test WARNING on stm32/stm32-next] [also build test WARNING on linus/master v5.14-rc4 next-20210803] [cannot apply to linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Introduce-the-Counter-character-device-interface/20210803-201000 base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next :::::: branch date: 11 hours ago :::::: commit date: 11 hours ago config: x86_64-randconfig-m001-20210803 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> New smatch warnings: drivers/counter/counter-chrdev.c:463 counter_get_data() error: uninitialized symbol 'ret'. Old smatch warnings: drivers/counter/counter-chrdev.c:482 counter_get_data() error: uninitialized symbol 'ret'. vim +/ret +463 drivers/counter/counter-chrdev.c 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 434 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 435 static int counter_get_data(struct counter_device *const counter, 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 436 const struct counter_comp_node *const comp_node, 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 437 u64 *const value) 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 438 { 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 439 const struct counter_comp *const comp = &comp_node->comp; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 440 void *const parent = comp_node->parent; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 441 u8 value_u8 = 0; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 442 u32 value_u32 = 0; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 443 int ret; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 444 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 445 if (comp_node->component.type == COUNTER_COMPONENT_NONE) 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 446 return 0; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 447 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 448 switch (comp->type) { 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 449 case COUNTER_COMP_U8: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 450 case COUNTER_COMP_BOOL: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 451 switch (comp_node->component.scope) { 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 452 case COUNTER_SCOPE_DEVICE: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 453 ret = comp->device_u8_read(counter, &value_u8); 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 454 break; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 455 case COUNTER_SCOPE_SIGNAL: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 456 ret = comp->signal_u8_read(counter, parent, &value_u8); 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 457 break; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 458 case COUNTER_SCOPE_COUNT: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 459 ret = comp->count_u8_read(counter, parent, &value_u8); 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 460 break; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 461 } 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 462 *value = value_u8; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 @463 return ret; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 464 case COUNTER_COMP_SIGNAL_LEVEL: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 465 case COUNTER_COMP_FUNCTION: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 466 case COUNTER_COMP_ENUM: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 467 case COUNTER_COMP_COUNT_DIRECTION: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 468 case COUNTER_COMP_COUNT_MODE: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 469 switch (comp_node->component.scope) { 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 470 case COUNTER_SCOPE_DEVICE: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 471 ret = comp->device_u32_read(counter, &value_u32); 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 472 break; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 473 case COUNTER_SCOPE_SIGNAL: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 474 ret = comp->signal_u32_read(counter, parent, 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 475 &value_u32); 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 476 break; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 477 case COUNTER_SCOPE_COUNT: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 478 ret = comp->count_u32_read(counter, parent, &value_u32); 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 479 break; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 480 } 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 481 *value = value_u32; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 482 return ret; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 483 case COUNTER_COMP_U64: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 484 switch (comp_node->component.scope) { 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 485 case COUNTER_SCOPE_DEVICE: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 486 return comp->device_u64_read(counter, value); 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 487 case COUNTER_SCOPE_SIGNAL: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 488 return comp->signal_u64_read(counter, parent, value); 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 489 case COUNTER_SCOPE_COUNT: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 490 return comp->count_u64_read(counter, parent, value); 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 491 default: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 492 return -EINVAL; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 493 } 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 494 case COUNTER_COMP_SYNAPSE_ACTION: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 495 ret = comp->action_read(counter, parent, comp->priv, 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 496 &value_u32); 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 497 *value = value_u32; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 498 return ret; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 499 default: 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 500 return -EINVAL; 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 501 } 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 502 } 3c9b0c3f9e4f8f William Breathitt Gray 2021-08-03 503 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ kbuild mailing list -- [email protected] To unsubscribe send an email to [email protected]
